diff options
author | Emile Anclin <emile.anclin@logilab.fr> | 2008-09-09 15:55:24 +0200 |
---|---|---|
committer | Emile Anclin <emile.anclin@logilab.fr> | 2008-09-09 15:55:24 +0200 |
commit | 4c76cd6fb38ce8e734f051ac44b682ebbd6b1f3d (patch) | |
tree | c85be49640bf3509948b808490a3d7d95b843add | |
parent | 3b55cc04c09f43755f7155c94195e351a3a7592a (diff) | |
download | pylint-4c76cd6fb38ce8e734f051ac44b682ebbd6b1f3d.tar.gz |
little simplifying
-rw-r--r-- | lint.py | 5 | ||||
-rw-r--r-- | utils.py | 11 |
2 files changed, 6 insertions, 10 deletions
@@ -456,8 +456,6 @@ This is used by the global evaluation report (R0004).'}), files_or_modules = (files_or_modules,) filemods = self.expand_files(files_or_modules) checkers = sort_checkers(self._checkers.values()) - rev_checkers = checkers[:] - rev_checkers.reverse() # notify global begin for checker in checkers: checker.open() @@ -492,7 +490,8 @@ This is used by the global evaluation report (R0004).'}), self.check_astng_module(astng, checkers) # notify global end self.set_current_module('') - for checker in rev_checkers: + checkers.reverse() + for checker in checkers: checker.close() def expand_files(self, files_or_modules): @@ -44,15 +44,12 @@ MSG_TYPES = { MSG_CATEGORIES = MSG_TYPES.keys() -def sort_checkers(checkers, enabled_only=True): +def sort_checkers(checkers, enabled_only=True): # XXX enabled_only never used ? """return a list of enabled checker sorted by priority""" if enabled_only: - checkers = [(-checker.priority, checker) for checker in checkers - if checker.is_enabled()] - else: - checkers = [(-checker.priority, checker) for checker in checkers] - checkers.sort() - return [item[1] for item in checkers] + checkers = [checker for checker in checkers if checker.is_enabled()] + checkers.sort(lambda x, y: cmp(-x.priority, -y.priority) ) + return checkers def sort_msgs(msg_ids): """sort message identifiers according to their category first""" |