fix false used-before-assignment for except handler defined identifier used on the same line (closes issue #111)

3 files changed, 14 insertions, 1 deletions

diff --git a/ChangeLog b/ChangeLog
index b6b4f8b..5c389a3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,9 +2,12 @@ ChangeLog for Pylint
 ====================
 
 --
+    * Avoid false used-before-assignment for except handler defined
+     identifier used on the same line (#111)
+
     * Add 'bad-context-manager' error, checking that '__exit__'
       special method accepts the right number of arguments.
- 
+
     * Run pylint as a python module 'python -m pylint' (anatoly techtonik)
 
     * Check for non-exception classes inside an except clause
diff --git a/checkers/utils.py b/checkers/utils.py
index 5e028f2..a064404 100644
--- a/checkers/utils.py
+++ b/checkers/utils.py
@@ -162,6 +162,11 @@ def is_defined_before(var_node):
             if getattr(_node, 'name', None) == varname:
                 return True
             break
+        elif isinstance(_node, astroid.ExceptHandler):
+            if isinstance(_node.name, astroid.AssName):
+                ass_node=_node.name
+                if ass_node.name == varname:
+                    return True
         _node = _node.parent
     # possibly multiple statements on the same line using semi colon separator
     stmt = var_node.statement()
diff --git a/test/input/func_noerror_used_before_assignment.py b/test/input/func_noerror_used_before_assignment.py
new file mode 100644
index 0000000..6ba0b88
--- /dev/null
+++ b/test/input/func_noerror_used_before_assignment.py
@@ -0,0 +1,5 @@
+# pylint: disable = line-too-long, multiple-statements, missing-module-attribute
+"""https://bitbucket.org/logilab/pylint/issue/111/false-positive-used-before-assignment-with"""
+
+try: raise IOError(1, "a")
+except IOError, err: print err