diff options
Diffstat (limited to 'pylint/checkers/logging.py')
| -rw-r--r-- | pylint/checkers/logging.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/pylint/checkers/logging.py b/pylint/checkers/logging.py index e074a18..ddfdc29 100644 --- a/pylint/checkers/logging.py +++ b/pylint/checkers/logging.py @@ -78,7 +78,7 @@ def is_method_call(callfunc_node, types=(), methods=()): True, if the node represents a method call for the given type and method names, False otherwise. """ - if not isinstance(callfunc_node, astroid.CallFunc): + if not isinstance(callfunc_node, astroid.Call): return False func = helpers.safe_infer(callfunc_node.func) return (isinstance(func, astroid.BoundMethod) @@ -139,7 +139,7 @@ class LoggingChecker(checkers.BaseChecker): def visit_callfunc(self, node): """Checks calls to logging methods.""" def is_logging_name(): - return (isinstance(node.func, astroid.Getattr) and + return (isinstance(node.func, astroid.Attribute) and isinstance(node.func.expr, astroid.Name) and node.func.expr.name in self._logging_names) @@ -148,7 +148,7 @@ class LoggingChecker(checkers.BaseChecker): for inferred in node.func.infer(): if isinstance(inferred, astroid.BoundMethod): parent = inferred._proxied.parent - if (isinstance(parent, astroid.Class) and + if (isinstance(parent, astroid.ClassDef) and (parent.qname() == 'logging.Logger' or any(ancestor.qname() == 'logging.Logger' for ancestor in parent.ancestors()))): @@ -184,7 +184,7 @@ class LoggingChecker(checkers.BaseChecker): if isinstance(node.args[format_pos], astroid.BinOp) and node.args[format_pos].op == '%': self.add_message('logging-not-lazy', node=node) - elif isinstance(node.args[format_pos], astroid.CallFunc): + elif isinstance(node.args[format_pos], astroid.Call): self._check_call_func(node.args[format_pos]) elif isinstance(node.args[format_pos], astroid.Const): self._check_format_string(node, format_pos) |