summaryrefslogtreecommitdiff
path: root/pylint/test/functional/misplaced_comparison_constant.py
diff options
context:
space:
mode:
Diffstat (limited to 'pylint/test/functional/misplaced_comparison_constant.py')
-rw-r--r--pylint/test/functional/misplaced_comparison_constant.py38
1 files changed, 38 insertions, 0 deletions
diff --git a/pylint/test/functional/misplaced_comparison_constant.py b/pylint/test/functional/misplaced_comparison_constant.py
new file mode 100644
index 0000000..df3f40e
--- /dev/null
+++ b/pylint/test/functional/misplaced_comparison_constant.py
@@ -0,0 +1,38 @@
+"""Check that the constants are on the right side of the comparisons"""
+
+# pylint: disable=singleton-comparison, missing-docstring, too-few-public-methods
+
+class MyClass(object):
+ def __init__(self):
+ self.attr = 1
+
+ def dummy_return(self):
+ return self.attr
+
+def dummy_return():
+ return 2
+
+def bad_comparisons():
+ """this is not ok"""
+ instance = MyClass()
+ for i in range(10):
+ if 5 <= i: # [misplaced-comparison-constant]
+ print "foo"
+ if True == True: # [misplaced-comparison-constant]
+ pass
+ if 'bar' != 'foo': # [misplaced-comparison-constant]
+ pass
+ if 1 == i: # [misplaced-comparison-constant]
+ print "bar"
+ if 3 < dummy_return(): # [misplaced-comparison-constant]
+ pass
+ if 4 != instance.dummy_return(): # [misplaced-comparison-constant]
+ pass
+ if 1 == instance.attr: # [misplaced-comparison-constant]
+ pass
+
+def good_comparison():
+ """this is ok"""
+ for i in range(10):
+ if i == 5:
+ print "foo"