From f873e60fd80772675a5523e8ff1395097494d23e Mon Sep 17 00:00:00 2001 From: Radu Ciorba Date: Sat, 9 May 2015 16:28:13 +0300 Subject: #518 fix unused-argument false positive when += is used --- pylint/checkers/variables.py | 5 +---- pylint/test/functional/undefined_variable.py | 2 +- pylint/test/functional/undefined_variable.txt | 1 - pylint/test/messages/func_w0612.txt | 1 - 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py index 45fd76d..83e4e5c 100644 --- a/pylint/checkers/variables.py +++ b/pylint/checkers/variables.py @@ -898,10 +898,7 @@ builtins. Remember that you should avoid to define new builtins when possible.' self.add_message('undefined-variable', args=name, node=node) - if isinstance(node, astroid.AssName): # Aug AssName - del consumed[name] - else: - del to_consume[name] + del to_consume[name] # check it's not a loop variable used outside the loop self._loopvar_name(node, name) break diff --git a/pylint/test/functional/undefined_variable.py b/pylint/test/functional/undefined_variable.py index 37e5407..e864659 100644 --- a/pylint/test/functional/undefined_variable.py +++ b/pylint/test/functional/undefined_variable.py @@ -23,7 +23,7 @@ def bad_default(var, default=unknown2): # [undefined-variable] """function with defaut arg's value set to an unexistant name""" print(var, default) print(xxxx) # [undefined-variable] - augvar += 1 # [undefined-variable,unused-variable] + augvar += 1 # [undefined-variable] del vardel # [undefined-variable] LMBD = lambda x, y=doesnotexist: x+y # [undefined-variable] diff --git a/pylint/test/functional/undefined_variable.txt b/pylint/test/functional/undefined_variable.txt index 497f320..c1c81bc 100644 --- a/pylint/test/functional/undefined_variable.txt +++ b/pylint/test/functional/undefined_variable.txt @@ -5,7 +5,6 @@ undefined-variable:18::Undefined variable '__revision__' undefined-variable:22:bad_default:Undefined variable 'unknown2' undefined-variable:25:bad_default:Undefined variable 'xxxx' undefined-variable:26:bad_default:Undefined variable 'augvar' -unused-variable:26:bad_default:Unused variable 'augvar' undefined-variable:27:bad_default:Undefined variable 'vardel' undefined-variable:29::Undefined variable 'doesnotexist' undefined-variable:30::Undefined variable 'z' diff --git a/pylint/test/messages/func_w0612.txt b/pylint/test/messages/func_w0612.txt index c81b4f9..752aa70 100644 --- a/pylint/test/messages/func_w0612.txt +++ b/pylint/test/messages/func_w0612.txt @@ -1,5 +1,4 @@ W: 9:function: Unused variable 'aaaa' -W: 10:function: Unused variable 'index' W: 34:test_global: Unused variable 'platform' W: 35:test_global: Unused variable 'VERSION' W: 36:test_global: Unused variable 'this' -- cgit v1.2.1