From eaf6aeb50f5bee0364bbac8aef557083dd34e37d Mon Sep 17 00:00:00 2001 From: Claudiu Popa Date: Sun, 11 Jan 2015 12:01:19 +0200 Subject: Add the method names for the 'signature-differs' and 'argument-differs' warnings. Closes issue #433. --- checkers/classes.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'checkers/classes.py') diff --git a/checkers/classes.py b/checkers/classes.py index 7b216fe..1a10c35 100644 --- a/checkers/classes.py +++ b/checkers/classes.py @@ -179,11 +179,11 @@ MSGS = { 'missing-interface-method', 'Used when a method declared in an interface is missing from a \ class implementing this interface'), - 'W0221': ('Arguments number differs from %s method', + 'W0221': ('Arguments number differs from %s %r method', 'arguments-differ', 'Used when a method has a different number of arguments than in \ the implemented interface or in an overridden method.'), - 'W0222': ('Signature differs from %s method', + 'W0222': ('Signature differs from %s %r method', 'signature-differs', 'Used when a method signature is different than in the \ implemented interface or in an overridden method.'), @@ -939,9 +939,13 @@ a metaclass class method.'} if is_attr_private(method1.name): return if len(method1.args.args) != len(refmethod.args.args): - self.add_message('arguments-differ', args=class_type, node=method1) + self.add_message('arguments-differ', + args=(class_type, method1.name), + node=method1) elif len(method1.args.defaults) < len(refmethod.args.defaults): - self.add_message('signature-differs', args=class_type, node=method1) + self.add_message('signature-differs', + args=(class_type, method1.name), + node=method1) def is_first_attr(self, node): """Check that attribute lookup name use first attribute variable name -- cgit v1.2.1