From f12378d90b206278b704624fadcdcbea15d13463 Mon Sep 17 00:00:00 2001 From: cpopa Date: Wed, 23 Jul 2014 09:25:37 +0200 Subject: Don't use set comprehension. --- checkers/strings.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'checkers') diff --git a/checkers/strings.py b/checkers/strings.py index 4fe16dd..ad63580 100644 --- a/checkers/strings.py +++ b/checkers/strings.py @@ -327,10 +327,10 @@ class StringMethodsChecker(BaseChecker): self.add_message('bad-format-string', node=node) return - manual_fields = {field[0] for field in fields - if isinstance(field[0], int)} - named_fields = {field[0] for field in fields - if isinstance(field[0], str)} + manual_fields = set(field[0] for field in fields + if isinstance(field[0], int)) + named_fields = set(field[0] for field in fields + if isinstance(field[0], str)) if manual_fields and num_args: self.add_message('format-combined-specification', node=node) -- cgit v1.2.1 From 4bdb95ad8d3d14fd419119c7ae379da3bddcb126 Mon Sep 17 00:00:00 2001 From: Sylvain Th?nault Date: Wed, 23 Jul 2014 12:36:42 +0200 Subject: stop having ASTWalker as BaseChecker base class, it's not used anymore (and for a while) --- checkers/__init__.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'checkers') diff --git a/checkers/__init__.py b/checkers/__init__.py index af7965b..693a5ff 100644 --- a/checkers/__init__.py +++ b/checkers/__init__.py @@ -42,7 +42,6 @@ import sys import tokenize import warnings -from astroid.utils import ASTWalker from logilab.common.configuration import OptionsProviderMixIn from pylint.reporters import diff_string @@ -69,7 +68,7 @@ def table_lines_from_stats(stats, old_stats, columns): return lines -class BaseChecker(OptionsProviderMixIn, ASTWalker): +class BaseChecker(OptionsProviderMixIn): """base class for checkers""" # checker name (you may reuse an existing one) name = None @@ -87,7 +86,6 @@ class BaseChecker(OptionsProviderMixIn, ASTWalker): linter is an object implementing ILinter """ - ASTWalker.__init__(self, self) self.name = self.name.lower() OptionsProviderMixIn.__init__(self) self.linter = linter -- cgit v1.2.1