1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
|
"""Verify if constant tests are used inside if statements."""
# pylint: disable=invalid-name, missing-docstring,too-few-public-methods
# pylint: disable=no-init,expression-not-assigned
import collections
def function():
yield
class Class(object):
def method(self):
pass
instance = Class()
if collections: # [using-constant-test]
pass
# GenExpr
if (node for node in range(10)): # [using-constant-test]
pass
if lambda: None: # [using-constant-test]
pass
if function: # [using-constant-test]
pass
if Class: # [using-constant-test]
pass
if 2: # [using-constant-test]
pass
if True: # [using-constant-test]
pass
if '': # [using-constant-test]
pass
if b'': # [using-constant-test]
pass
if 2.0: # [using-constant-test]
pass
if {}: # [using-constant-test]
pass
if {1, 2, 3}: # [using-constant-test]
pass
if (1, 2, 3): # [using-constant-test]
pass
if (): # [using-constant-test]
pass
# Generator
generator = function()
if generator: # [using-constant-test]
pass
if 1 if 2 else 3: # [using-constant-test]
pass
def test_comprehensions():
[data for data in range(100) if len] # [using-constant-test]
[data for data in range(100) if 1] # [using-constant-test]
(data for data in range(100) if len) # [using-constant-test]
(data for data in range(100) if 1) # [using-constant-test]
{data for data in range(100) if len} # [using-constant-test]
{data: 1 for data in range(100) if len} # [using-constant-test]
# For these, we require to do inference, even though the result can be a
# constant value. For some of them, we could determine that the test
# is constant, such as 2 + 3, but the components of the BinOp
# can be anything else (2 + somefunccall).
name = 42
if name:
pass
# UnboundMethod / Function
if Class.method:
pass
# BoundMethod
if instance.method:
pass
if 3 + 4:
pass
if 3 and 4:
pass
if not 3:
pass
if instance.method():
pass
if 2 < 3:
pass
if tuple((1, 2, 3)):
pass
if dict():
pass
if tuple():
pass
if [1, 2, 3][:1]:
pass
def test(*args):
if args:
return 42
def test_good_comprehension_checks():
[data for data in range(100)]
[data for data in range(100) if data]
[data for data in range(100) if len(data)]
(data for data in range(100) if data)
(data for data in range(100) if len(data))
{data for data in range(100) if data}
{data for data in range(100) if len(data)}
{data: 1 for data in range(100) if data}
{data: 1 for data in range(100)}
|
