1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
|
# Copyright 2014 Google Inc.
# This program is free software; you can redistribute it and/or modify it under
# the terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# this program; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
"""Tests for the python3 checkers."""
from __future__ import absolute_import
import sys
import unittest
from astroid import test_utils
from pylint import testutils
from pylint.checkers import python3 as checker
def python2_only(test):
"""Decorator for any tests that will fail under Python 3."""
return unittest.skipIf(sys.version_info[0] > 2, 'Python 2 only')(test)
class Python3CheckerTest(testutils.CheckerTestCase):
CHECKER_CLASS = checker.Python3Checker
def check_bad_builtin(self, builtin_name):
node = test_utils.extract_node(builtin_name + ' #@')
message = builtin_name.lower() + '-builtin'
with self.assertAddsMessages(testutils.Message(message, node=node)):
self.checker.visit_name(node)
@python2_only
def test_apply_builtin(self):
self.check_bad_builtin('apply')
@python2_only
def test_buffer_builtin(self):
self.check_bad_builtin('buffer')
@python2_only
def test_cmp_builtin(self):
self.check_bad_builtin('cmp')
@python2_only
def test_coerce_builtin(self):
self.check_bad_builtin('coerce')
@python2_only
def test_execfile_builtin(self):
self.check_bad_builtin('execfile')
@python2_only
def test_file_builtin(self):
self.check_bad_builtin('file')
@python2_only
def test_long_builtin(self):
self.check_bad_builtin('long')
@python2_only
def test_raw_input_builtin(self):
self.check_bad_builtin('raw_input')
@python2_only
def test_reduce_builtin(self):
self.check_bad_builtin('reduce')
@python2_only
def test_StandardError_builtin(self):
self.check_bad_builtin('StandardError')
@python2_only
def test_unicode_builtin(self):
self.check_bad_builtin('unicode')
@python2_only
def test_xrange_builtin(self):
self.check_bad_builtin('xrange')
def test_delslice_method(self):
node = test_utils.extract_node("""
class Foo(object):
def __delslice__(self, i, j): #@
pass""")
message = testutils.Message('delslice-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_function(node)
def test_getslice_method(self):
node = test_utils.extract_node("""
class Foo(object):
def __getslice__(self, i, j): #@
pass""")
message = testutils.Message('getslice-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_function(node)
def test_setslice_method(self):
node = test_utils.extract_node("""
class Foo(object):
def __setslice__(self, i, j, value): #@
pass""")
message = testutils.Message('setslice-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_function(node)
def test_coerce_method(self):
node = test_utils.extract_node("""
class Foo(object):
def __coerce__(self, other): #@
pass""")
message = testutils.Message('coerce-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_function(node)
@python2_only
def test_print_statement(self):
node = test_utils.extract_node('print "Hello, World!" #@')
message = testutils.Message('print-statement', node=node)
with self.assertAddsMessages(message):
self.checker.visit_print(node)
def test_relative_import(self):
node = test_utils.extract_node('import string #@')
message = testutils.Message('no-absolute-import', node=node)
with self.assertAddsMessages(message):
self.checker.visit_import(node)
def test_relative_from_import(self):
node = test_utils.extract_node('from os import path #@')
message = testutils.Message('no-absolute-import', node=node)
with self.assertAddsMessages(message):
self.checker.visit_import(node)
def test_absolute_import(self):
module_import = test_utils.build_module(
'from __future__ import absolute_import; import os')
module_from = test_utils.build_module(
'from __future__ import absolute_import; from os import path')
with self.assertNoMessages():
for module in (module_import, module_from):
self.walk(module)
def test_division(self):
node = test_utils.extract_node('3 / 2 #@')
message = testutils.Message('old-division', node=node)
with self.assertAddsMessages(message):
self.checker.visit_binop(node)
def test_division_with_future_statement(self):
module = test_utils.build_module('from __future__ import division; 3 / 2')
with self.assertNoMessages():
self.walk(module)
def test_floor_division(self):
node = test_utils.extract_node(' 3 // 2 #@')
with self.assertNoMessages():
self.checker.visit_binop(node)
def test_division_by_float(self):
left_node = test_utils.extract_node('3.0 / 2 #@')
right_node = test_utils.extract_node(' 3 / 2.0 #@')
with self.assertNoMessages():
for node in (left_node, right_node):
self.checker.visit_binop(node)
def test_dict_iter_method(self):
for meth in ('keys', 'values', 'items'):
node = test_utils.extract_node('x.iter%s() #@' % meth)
message = testutils.Message('dict-iter-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_callfunc(node)
def test_dict_iter_method_on_dict(self):
node = test_utils.extract_node('{}.iterkeys()')
message = testutils.Message('dict-iter-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_callfunc(node)
def test_dict_not_iter_method(self):
arg_node = test_utils.extract_node('x.iterkeys(x) #@')
stararg_node = test_utils.extract_node('x.iterkeys(*x) #@')
kwarg_node = test_utils.extract_node('x.iterkeys(y=x) #@')
non_dict_node = test_utils.extract_node('x=[]\nx.iterkeys() #@')
with self.assertNoMessages():
for node in (arg_node, stararg_node, kwarg_node, non_dict_node):
self.checker.visit_callfunc(node)
def test_dict_view_method(self):
for meth in ('keys', 'values', 'items'):
node = test_utils.extract_node('x.view%s() #@' % meth)
message = testutils.Message('dict-view-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_callfunc(node)
def test_dict_view_method_on_dict(self):
node = test_utils.extract_node('{}.viewkeys()')
message = testutils.Message('dict-view-method', node=node)
with self.assertAddsMessages(message):
self.checker.visit_callfunc(node)
def test_dict_not_view_method(self):
arg_node = test_utils.extract_node('x.viewkeys(x) #@')
stararg_node = test_utils.extract_node('x.viewkeys(*x) #@')
kwarg_node = test_utils.extract_node('x.viewkeys(y=x) #@')
non_dict_node = test_utils.extract_node('x=[]\nx.viewkeys() #@')
with self.assertNoMessages():
for node in (arg_node, stararg_node, kwarg_node, non_dict_node):
self.checker.visit_callfunc(node)
def test_next_method(self):
node = test_utils.extract_node('x.next() #@')
message = testutils.Message('next-method-called', node=node)
with self.assertAddsMessages(message):
self.checker.visit_callfunc(node)
def test_not_next_method(self):
arg_node = test_utils.extract_node('x.next(x) #@')
stararg_node = test_utils.extract_node('x.next(*x) #@')
kwarg_node = test_utils.extract_node('x.next(y=x) #@')
with self.assertNoMessages():
for node in (arg_node, stararg_node, kwarg_node):
self.checker.visit_callfunc(node)
def test_metaclass_assignment(self):
node = test_utils.extract_node("""
class Foo(object): #@
__metaclass__ = type""")
message = testutils.Message('metaclass-assignment', node=node)
with self.assertAddsMessages(message):
self.checker.visit_class(node)
def test_metaclass_global_assignment(self):
module = test_utils.build_module('__metaclass__ = type')
with self.assertNoMessages():
self.walk(module)
@python2_only
def test_parameter_unpacking(self):
node = test_utils.extract_node('def func((a, b)):#@\n pass')
arg = node.args.args[0]
with self.assertAddsMessages(testutils.Message('parameter-unpacking', node=arg)):
self.walk(node)
if __name__ == '__main__':
unittest.main()
|