Refactor create_authn_request provider_name

Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>

1 files changed, 5 insertions, 8 deletions

diff --git a/src/saml2/client_base.py b/src/saml2/client_base.py
index 32346c85..e717dc6e 100644
--- a/src/saml2/client_base.py
+++ b/src/saml2/client_base.py
@@ -332,14 +332,11 @@ class Base(Entity):
         elif service_url:
             args["assertion_consumer_service_url"] = service_url
 
-
-        try:
-            args["provider_name"] = kwargs["provider_name"]
-        except KeyError:
-            if binding == BINDING_PAOS:
-                pass
-            else:
-                args["provider_name"] = self._my_name()
+        # ProviderName
+        provider_name = kwargs.get("provider_name")
+        if not provider_name and binding != BINDING_PAOS:
+            provider_name = self._my_name()
+        args["provider_name"] = provider_name
 
         # Allow argument values either as class instances or as dictionaries
         # all of these have cardinality 0..1