diff options
| author | Richard van der Hoff <richard@matrix.org> | 2020-08-10 19:42:29 +0100 |
|---|---|---|
| committer | Richard van der Hoff <richard@matrix.org> | 2020-08-10 19:42:29 +0100 |
| commit | 3d7e0b97e9d23ad721560c3a6599d78de09c0401 (patch) | |
| tree | abb96102d22bff9360be555b36e83483026bc110 | |
| parent | e5d0b4f0760144430d885165d41d777b59ef5d6a (diff) | |
| download | pysaml2-3d7e0b97e9d23ad721560c3a6599d78de09c0401.tar.gz | |
Remove spurious `exception` logging
These two `logger.exception` calls are both incorrect, because neither are in
an `except` block - which means that they will log a stacktrace for whatever
the most recent exception was (which may be wholly unrelated).
| -rw-r--r-- | src/saml2/response.py | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/saml2/response.py b/src/saml2/response.py index f2e2f53e..bcf3285f 100644 --- a/src/saml2/response.py +++ b/src/saml2/response.py @@ -526,8 +526,6 @@ class AuthnResponse(StatusResponse): try: if not self.check_subject_confirmation_in_response_to( self.in_response_to): - logger.exception( - "Unsolicited response %s" % self.in_response_to) raise UnsolicitedResponse( "Unsolicited response: %s" % self.in_response_to) except AttributeError: @@ -536,8 +534,6 @@ class AuthnResponse(StatusResponse): # Should check that I haven't seen this before pass else: - logger.exception( - "Unsolicited response %s" % self.in_response_to) raise UnsolicitedResponse( "Unsolicited response: %s" % self.in_response_to) |