Allow deployers to override default True parameters

1 files changed, 12 insertions, 5 deletions

diff --git a/src/saml2/client_base.py b/src/saml2/client_base.py
index 997e43e4..94531d77 100644
--- a/src/saml2/client_base.py
+++ b/src/saml2/client_base.py
@@ -108,16 +108,23 @@ class Base(Entity):
         else:
             self.state = state_cache
 
+        # Handle values which are False by default
         self.logout_requests_signed = False
         self.allow_unsolicited = False
         self.authn_requests_signed = False
         self.want_assertions_signed = False
-        self.want_response_signed = True
-        for foo in ["allow_unsolicited", "authn_requests_signed",
-                    "logout_requests_signed", "want_assertions_signed"]:
-            v = self.config.getattr(foo, "sp")
+        for param in ["allow_unsolicited", "authn_requests_signed",
+                      "logout_requests_signed", "want_assertions_signed"]:
+            v = self.config.getattr(param, "sp")
             if v is True or v == 'true':
-                setattr(self, foo, True)
+                setattr(self, param, True)
+
+        # Handle values which are True by default
+        self.want_response_signed = True
+        for param in ["want_assertions_signed"]:
+            v = self.config.getattr(param, "sp")
+            if v is False or v == 'false':
+                setattr(self, param, False)
 
         self.artifact2response = {}