summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Kanakarakis <ivan.kanak@gmail.com>2019-05-14 15:26:20 +0200
committerIvan Kanakarakis <ivan.kanak@gmail.com>2019-05-14 15:26:20 +0200
commite86a489c353ee3e5e48712f4b85a5e4c4656a0e3 (patch)
tree9592ea63e2c85a3e493f9d1a87f7081cd9bd9a00
parent80ec58db830d90f97f4bfd584a7023fe2c99ce4b (diff)
downloadpysaml2-e86a489c353ee3e5e48712f4b85a5e4c4656a0e3.tar.gz
Escape single and double quotes, always
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
-rw-r--r--src/saml2/pack.py10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/saml2/pack.py b/src/saml2/pack.py
index fc651645..5a2534c2 100644
--- a/src/saml2/pack.py
+++ b/src/saml2/pack.py
@@ -68,6 +68,10 @@ HTML_FORM_SPEC = """<!DOCTYPE html>
</html>"""
+def _html_escape(payload):
+ return html.escape(payload, quote=True)
+
+
def http_form_post_message(message, location, relay_state="",
typ="SAMLRequest", **kwargs):
"""The HTTP POST binding defines a mechanism by which SAML protocol
@@ -91,15 +95,15 @@ def http_form_post_message(message, location, relay_state="",
_msg = _msg.decode('ascii')
saml_response_input = HTML_INPUT_ELEMENT_SPEC.format(
- name=html.escape(typ),
- val=html.escape(_msg),
+ name=_html_escape(typ),
+ val=_html_escape(_msg),
type='hidden')
relay_state_input = ""
if relay_state:
relay_state_input = HTML_INPUT_ELEMENT_SPEC.format(
name='RelayState',
- val=html.escape(relay_state),
+ val=_html_escape(relay_state),
type='hidden')
response = HTML_FORM_SPEC.format(