summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Kanakarakis <ivan.kanak@gmail.com>2020-12-29 18:42:33 +0200
committerGitHub <noreply@github.com>2020-12-29 18:42:33 +0200
commitd440116aa48b73f24141aeba86ee226052ae9f02 (patch)
treefcc81985fc7b8037d665726aa1a43570612211d8
parent87be05ba17a5b24dc3294a89cdf569e02e9414d6 (diff)
parentd2e775aa1af2a2a350a6eb0cfe2adb3c34693b57 (diff)
downloadpysaml2-d440116aa48b73f24141aeba86ee226052ae9f02.tar.gz
Merge pull request #758 from peppelinux/statusresp_return_addrs
Fix StatusResponse when return_addrs is not set
-rw-r--r--src/saml2/response.py11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/saml2/response.py b/src/saml2/response.py
index 5fd8043a..50e4f6b0 100644
--- a/src/saml2/response.py
+++ b/src/saml2/response.py
@@ -255,7 +255,7 @@ class StatusResponse(object):
def __init__(self, sec_context, return_addrs=None, timeslack=0,
request_id=0, asynchop=True, conv_info=None):
self.sec = sec_context
- self.return_addrs = return_addrs
+ self.return_addrs = return_addrs or []
self.timeslack = timeslack
self.request_id = request_id
@@ -402,10 +402,11 @@ class StatusResponse(object):
raise RequestVersionTooHigh()
if self.asynchop:
- if self.response.destination and \
- self.response.destination not in self.return_addrs:
- logger.error("%s not in %s", self.response.destination,
- self.return_addrs)
+ if (
+ self.response.destination
+ and self.response.destination not in self.return_addrs
+ ):
+ logger.error("%s not in %s", self.response.destination, self.return_addrs)
return None
valid = self.issue_instant_ok() and self.status_ok()