diff options
author | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2021-03-07 20:39:53 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-03-07 20:39:53 +0200 |
commit | a0539a2444b93dc8a4989ea0769cd4242a53ec58 (patch) | |
tree | bccec4ae6ce92cef929a6cc789afe8e14ba8d33a | |
parent | 745c5921867f5e9c98f31a250fa98f5dd7c948d7 (diff) | |
parent | 072f8142c8cd06a45f3f8bd6e087df7e895b966b (diff) | |
download | pysaml2-a0539a2444b93dc8a4989ea0769cd4242a53ec58.tar.gz |
Merge pull request #779 from peppelinux/metadata_exp_handler
Raise SAMLError on failure to parse a metadata file
-rw-r--r-- | src/saml2/mdstore.py | 8 | ||||
-rw-r--r-- | tests/invalid_metadata_file.xml | 1 | ||||
-rw-r--r-- | tests/test_30_mdstore.py | 13 |
3 files changed, 19 insertions, 3 deletions
diff --git a/src/saml2/mdstore.py b/src/saml2/mdstore.py index 96acfa1e..44930773 100644 --- a/src/saml2/mdstore.py +++ b/src/saml2/mdstore.py @@ -7,12 +7,12 @@ import os import sys from itertools import chain from warnings import warn as _warn - from hashlib import sha1 from os.path import isfile from os.path import join import requests + import six from saml2 import md @@ -24,7 +24,6 @@ from saml2 import SAMLError from saml2 import BINDING_HTTP_REDIRECT from saml2 import BINDING_HTTP_POST from saml2 import BINDING_SOAP - from saml2.httpbase import HTTPBase from saml2.extension.idpdisc import BINDING_DISCO from saml2.extension.idpdisc import DiscoveryResponse @@ -612,7 +611,10 @@ class InMemoryMetaData(MetaData): self.entity[entity_descr.entity_id] = _ent def parse(self, xmlstr): - self.entities_descr = md.entities_descriptor_from_string(xmlstr) + try: + self.entities_descr = md.entities_descriptor_from_string(xmlstr) + except Exception as e: + raise SAMLError(f'Failed to parse metadata file: {self.filename}') from e if not self.entities_descr: self.entity_descr = md.entity_descriptor_from_string(xmlstr) diff --git a/tests/invalid_metadata_file.xml b/tests/invalid_metadata_file.xml new file mode 100644 index 00000000..249c87ce --- /dev/null +++ b/tests/invalid_metadata_file.xml @@ -0,0 +1 @@ +this content is invalid diff --git a/tests/test_30_mdstore.py b/tests/test_30_mdstore.py index 4dfa80f3..bfe261dd 100644 --- a/tests/test_30_mdstore.py +++ b/tests/test_30_mdstore.py @@ -7,6 +7,8 @@ from collections import OrderedDict from unittest.mock import Mock from unittest.mock import patch +from pytest import raises + import responses from six.moves.urllib import parse @@ -19,6 +21,7 @@ from saml2.mdstore import locations from saml2.mdstore import name from saml2 import sigver from saml2.httpbase import HTTPBase +from saml2 import SAMLError from saml2 import BINDING_SOAP from saml2 import BINDING_HTTP_REDIRECT from saml2 import BINDING_HTTP_POST @@ -156,6 +159,10 @@ METADATACONF = { "class": "saml2.mdstore.MetaDataFile", "metadata": [(full_path("swamid-2.0.xml"),)], }], + "14": [{ + "class": "saml2.mdstore.MetaDataFile", + "metadata": [(full_path("invalid_metadata_file.xml"),)], + }], } @@ -170,6 +177,12 @@ def _fix_valid_until(xmlstring): xmlstring) +def test_invalid_metadata(): + mds = MetadataStore(ATTRCONV, sec_config, disable_ssl_certificate_validation=True) + with raises(SAMLError): + mds.imp(METADATACONF["14"]) + + def test_swami_1(): UMU_IDP = 'https://idp.umu.se/saml2/idp/metadata.php' mds = MetadataStore(ATTRCONV, sec_config, |