diff options
author | Jozef Knaperek <jknaperek@gmail.com> | 2015-10-12 16:22:19 +0200 |
---|---|---|
committer | Jozef Knaperek <jknaperek@gmail.com> | 2015-10-15 15:33:10 +0200 |
commit | c7febbf9e8c85355dccb53a326a51bfc41db1c66 (patch) | |
tree | 976664df2088314a431be719f64359448ddf17e9 /src/saml2/assertion.py | |
parent | 1228db66eb006e0f069cc1b6b1612c6cbaa8df1d (diff) | |
download | pysaml2-c7febbf9e8c85355dccb53a326a51bfc41db1c66.tar.gz |
Fix paramter passing in logging messages
Pass parameters into logger calls directly instead of pre-merging
with the logger message. This way the logs are easier to maintain
and process. The code is also faster when logging is turned off
since it doesn't have to evaluate all params and render them into
strings.
Diffstat (limited to 'src/saml2/assertion.py')
-rw-r--r-- | src/saml2/assertion.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/saml2/assertion.py b/src/saml2/assertion.py index 795c0cd8..c9d138bf 100644 --- a/src/saml2/assertion.py +++ b/src/saml2/assertion.py @@ -356,7 +356,7 @@ class Policy(object): _are[key.lower()] = [re.compile(value) for value in values] spec["attribute_restrictions"] = _are - logger.debug("policy restrictions: %s" % self._restrictions) + logger.debug("policy restrictions: %s", self._restrictions) return self._restrictions @@ -486,7 +486,7 @@ class Policy(object): _ava = None if required or optional: - logger.debug("required: %s, optional: %s" % (required, optional)) + logger.debug("required: %s, optional: %s", required, optional) _ava = filter_on_attributes( ava.copy(), required, optional, self.acs, self.get_fail_on_missing_requested(sp_entity_id)) |