Fix Name-ID caching type inconsistency

If we already promoted (in #0515de9f) the saml2.cache.Cache to be a bit smart when it
comes to understanding the data it stores - that is decoding name_id in the get() method,
let's be consistent and do the reverse operation directly in the set() method.

This also fixes the issue with djangosaml2 that PR #321 tried to solve (but ugly way).

1 files changed, 5 insertions, 0 deletions

diff --git a/src/saml2/cache.py b/src/saml2/cache.py
index 5b72e9d1..2e2eaa9a 100644
--- a/src/saml2/cache.py
+++ b/src/saml2/cache.py
@@ -113,6 +113,11 @@ class Cache(object):
         :param info: The session info, the assertion is part of this
         :param not_on_or_after: A time after which the assertion is not valid.
         """
+        info = dict(info)
+        if 'name_id' in info and not isinstance(info['name_id'], six.string_types):
+            # make friendly to (JSON) serialization
+            info['name_id'] = code(name_id)
+
         cni = code(name_id)
         if cni not in self._db:
             self._db[cni] = {}