diff options
author | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-09-10 02:28:38 +0300 |
---|---|---|
committer | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-09-11 02:11:12 +0300 |
commit | bc96c3856dfd6ffbd27e0f59acacfef2b71e4edd (patch) | |
tree | 543f78595d25fd3127199e26917df9b3c67c156b /src/saml2/saml.py | |
parent | 7b1b52e03f06310bc23f688fe3f373881950a9f7 (diff) | |
download | pysaml2-bc96c3856dfd6ffbd27e0f59acacfef2b71e4edd.tar.gz |
Replace assert with proper checksassert_deletion
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
Diffstat (limited to 'src/saml2/saml.py')
-rw-r--r-- | src/saml2/saml.py | 27 |
1 files changed, 17 insertions, 10 deletions
diff --git a/src/saml2/saml.py b/src/saml2/saml.py index e551bcb6..9753def0 100644 --- a/src/saml2/saml.py +++ b/src/saml2/saml.py @@ -116,8 +116,14 @@ class AttributeValueBase(SamlBase): def verify(self): if not self.text: - assert self.extension_attributes - assert self.extension_attributes[XSI_NIL] == "true" + if not self.extension_attributes: + raise Exception( + "Attribute value base should not have extension attributes" + ) + if self.extension_attributes[XSI_NIL] != "true": + raise Exception( + "Attribute value base should not have extension attributes" + ) return True else: SamlBase.verify(self) @@ -1029,12 +1035,11 @@ class AuthnContextType_(SamlBase): self.authenticating_authority = authenticating_authority or [] def verify(self): - # either <AuthnContextDecl> or <AuthnContextDeclRef> not both - if self.authn_context_decl: - assert self.authn_context_decl_ref is None - elif self.authn_context_decl_ref: - assert self.authn_context_decl is None - + if self.authn_context_decl and self.authn_context_decl_ref: + raise Exception( + "Invalid Response: " + "Cannot have both <AuthnContextDecl> and <AuthnContextDeclRef>" + ) return SamlBase.verify(self) @@ -1264,9 +1269,11 @@ class ConditionsType_(SamlBase): def verify(self): if self.one_time_use: - assert len(self.one_time_use) == 1 + if len(self.one_time_use) != 1: + raise Exception("Cannot be used more than once") if self.proxy_restriction: - assert len(self.proxy_restriction) == 1 + if len(self.proxy_restriction) != 1: + raise Exception("Cannot be used more than once") return SamlBase.verify(self) |