Raise exception instead of returning empty string.

1 files changed, 5 insertions, 1 deletions

diff --git a/src/saml2/soap.py b/src/saml2/soap.py
index 6f95ad54..e172e7d9 100644
--- a/src/saml2/soap.py
+++ b/src/saml2/soap.py
@@ -39,6 +39,9 @@ logger = logging.getLogger(__name__)
 class XmlParseError(Exception):
     pass
 
+class WrongMessageType(Exception):
+    pass
+
 def parse_soap_enveloped_saml_response(text):
     tags = ['{%s}Response' % SAMLP_NAMESPACE, 
             '{%s}LogoutResponse' % SAMLP_NAMESPACE]
@@ -103,7 +106,8 @@ def parse_soap_enveloped_saml_thingy(text, expected_tags):
     if saml_part.tag in expected_tags:
         return ElementTree.tostring(saml_part, encoding="UTF-8")
     else:
-        return ""
+        raise WrongMessageType("Was '%s' expected '%s'" % (saml_part.tag,
+                                                            expected_tags))
 
 import re