diff options
author | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-04-21 20:46:03 +0300 |
---|---|---|
committer | Ivan Kanakarakis <ivan.kanak@gmail.com> | 2020-05-12 13:43:30 +0300 |
commit | 832d26f26b4e7d0eb91689a5214119ccc610193f (patch) | |
tree | 2ae0d6b81c86d54fbd447a0a6e6a0b81bcac1e12 /tests | |
parent | 24d248cf29597264ec9db0b118946395c399c650 (diff) | |
download | pysaml2-832d26f26b4e7d0eb91689a5214119ccc610193f.tar.gz |
Remove logger configuration
```
************* Module saml2.config
src/saml2/config.py:464:23: E1135: Value '_logconf' doesn't support membership test (unsupported-membership-test)
src/saml2/config.py:466:27: E1136: Value '_logconf' is unsubscriptable (unsubscriptable-object)
src/saml2/config.py:481:50: E1136: Value '_logconf' is unsubscriptable (unsubscriptable-object)
src/saml2/config.py:486:22: E1120: No value for argument 'filename' in constructor call (no-value-for-parameter)
src/saml2/config.py:488:23: E1135: Value '_logconf' doesn't support membership test (unsupported-membership-test)
src/saml2/config.py:489:42: E1136: Value '_logconf' is unsubscriptable (unsubscriptable-object)
src/saml2/config.py:505:43: E1136: Value '_logconf' is unsubscriptable (unsubscriptable-object)
src/saml2/config.py:552:19: E1136: Value 'self.virtual_organization' is unsubscriptable (unsubscriptable-object)
```
this seems right; the operations upon the Logger object do not make sense.
There is no need to "fix" this, we just remove the relevant code.
We should come back to this and refactor how the logger is configured for the library.
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/test_31_config.py | 49 |
1 files changed, 2 insertions, 47 deletions
diff --git a/tests/test_31_config.py b/tests/test_31_config.py index 407e46e2..bb19d85c 100644 --- a/tests/test_31_config.py +++ b/tests/test_31_config.py @@ -8,7 +8,7 @@ from saml2.mdstore import MetadataStore, name from saml2 import BINDING_HTTP_REDIRECT, BINDING_SOAP, BINDING_HTTP_POST from saml2.config import SPConfig, IdPConfig, Config -from saml2 import root_logger +from saml2 import logger from pathutils import dotname, full_path from saml2.sigver import security_context, CryptoBackendXMLSecurity @@ -297,57 +297,12 @@ def test_wayf(): assert name(ent) == 'Example Co.' assert name(ent, "se") == 'Exempel AB' - c.setup_logger() - - assert root_logger.level != logging.NOTSET - assert root_logger.level == logging.INFO - assert len(root_logger.handlers) == 1 - assert isinstance(root_logger.handlers[0], - logging.handlers.RotatingFileHandler) - handler = root_logger.handlers[0] - assert handler.backupCount == 5 - try: - assert handler.maxBytes == 100000 - except AssertionError: - assert handler.maxBytes == 500000 - assert handler.mode == "a" - assert root_logger.name == "saml2" - assert root_logger.level == 20 - def test_conf_syslog(): c = SPConfig().load_file("server_conf_syslog") c.context = "sp" - # otherwise the logger setting is not changed - root_logger.level = logging.NOTSET - while root_logger.handlers: - handler = root_logger.handlers[-1] - root_logger.removeHandler(handler) - handler.flush() - handler.close() - - print(c.logger) - c.setup_logger() - - assert root_logger.level != logging.NOTSET - assert root_logger.level == logging.INFO - assert len(root_logger.handlers) == 1 - assert isinstance(root_logger.handlers[0], - logging.handlers.SysLogHandler) - handler = root_logger.handlers[0] - print(handler.__dict__) - assert handler.facility == "local3" - assert handler.address == ('localhost', 514) - if ((sys.version_info.major == 2 and sys.version_info.minor >= 7) or - sys.version_info.major > 2): - assert handler.socktype == 2 - else: - pass - assert root_logger.name == "saml2" - assert root_logger.level == 20 - -#noinspection PyUnresolvedReferences + def test_3(): cnf = Config() cnf.load_file(dotname("sp_1_conf")) |