From 6e90788b40edecb5d649679cc8395677d1ced6ed Mon Sep 17 00:00:00 2001 From: Vlad Mencl Date: Tue, 20 Jul 2021 15:12:16 +1200 Subject: fix: saml2.Entity/reload_metadata: use self.entity_type instead of iterating over all types As per review suggestion in #809 --- src/saml2/entity.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/saml2/entity.py b/src/saml2/entity.py index ad9d2d08..f6ca396c 100644 --- a/src/saml2/entity.py +++ b/src/saml2/entity.py @@ -226,11 +226,10 @@ class Entity(HTTPBase): logger.debug("Applying new metadata to main config") ( self.metadata, self.sec.metadata, self.config.metadata ) = [new_metadata]*3 - for typ in ["aa", "idp", "sp", "pdp", "aq"]: - policy = getattr(self.config, "_%s_policy" % typ, None) - if policy and policy.metadata_store: - logger.debug("Applying new metadata to %s policy", typ) - policy.metadata_store = self.metadata + policy = getattr(self.config, "_%s_policy" % self.entity_type, None) + if policy and policy.metadata_store: + logger.debug("Applying new metadata to %s policy", self.entity_type) + policy.metadata_store = self.metadata logger.debug("Applying new metadata source_id") self.sourceid = self.metadata.construct_source_id() -- cgit v1.2.1