From aea4d6a0dd052b3fa28e1b00c9922bf31326673c Mon Sep 17 00:00:00 2001
From: Jon Dufresne <jon.dufresne@gmail.com>
Date: Fri, 6 Oct 2017 08:02:05 -0400
Subject: Clean up unclosed files causing  ResourceWarnings in tests

* Use better subprocess functions to correctly close pipes.
* When opening files, use a context manager to ensure file is closed
  in a deterministic way.
* Close logging handlers
---
 tests/test_31_config.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'tests/test_31_config.py')

diff --git a/tests/test_31_config.py b/tests/test_31_config.py
index eb8480c6..189d3109 100644
--- a/tests/test_31_config.py
+++ b/tests/test_31_config.py
@@ -322,7 +322,11 @@ def test_conf_syslog():
 
     # otherwise the logger setting is not changed
     root_logger.level = logging.NOTSET
-    root_logger.handlers = []
+    while root_logger.handlers:
+        handler = root_logger.handlers[-1]
+        root_logger.removeHandler(handler)
+        handler.flush()
+        handler.close()
 
     print(c.logger)
     c.setup_logger()
-- 
cgit v1.2.1