summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Liechti <cliechti@gmx.net>2016-10-05 03:32:36 +0200
committerChris Liechti <cliechti@gmx.net>2016-10-05 03:32:36 +0200
commit8c05ebf1b7e8fef141f2a617e99db47f17d27186 (patch)
tree3427a8451eaedfc1871b33ca47f82f3e1a4b1c71
parent4f712110f380e4ad497c21481acd4267da960a4a (diff)
downloadpyserial-git-8c05ebf1b7e8fef141f2a617e99db47f17d27186.tar.gz
test_cancel: make tests a little less timing sensitive
- increase resolution of sleep/check in loop:/ - add 0.5s more tolerance to tests
-rw-r--r--serial/urlhandler/protocol_loop.py4
-rw-r--r--test/test_cancel.py4
2 files changed, 4 insertions, 4 deletions
diff --git a/serial/urlhandler/protocol_loop.py b/serial/urlhandler/protocol_loop.py
index 5bba4d3..7bf6cf9 100644
--- a/serial/urlhandler/protocol_loop.py
+++ b/serial/urlhandler/protocol_loop.py
@@ -189,8 +189,8 @@ class Serial(SerialBase):
# must wait so that unit test succeeds
time_left = self._write_timeout
while time_left > 0 and not self._cancel_write:
- time.sleep(min(time_left, 1))
- time_left -= 1
+ time.sleep(min(time_left, 0.5))
+ time_left -= 0.5
if self._cancel_write:
return 0 # XXX
raise writeTimeoutError
diff --git a/test/test_cancel.py b/test/test_cancel.py
index ce030a3..daab1ce 100644
--- a/test/test_cancel.py
+++ b/test/test_cancel.py
@@ -45,7 +45,7 @@ class TestCancelRead(unittest.TestCase):
self.s.read(1000)
t2 = time.time()
self.assertEqual(self.cancel_called, 1)
- self.assertTrue(0.5 < (t2 - t1) < 2, 'Function did not return in time: {}'.format(t2 - t1))
+ self.assertTrue(0.5 < (t2 - t1) < 2.5, 'Function did not return in time: {}'.format(t2 - t1))
#~ self.assertTrue(not self.s.isOpen())
#~ self.assertRaises(serial.SerialException, self.s.open)
@@ -89,7 +89,7 @@ class TestCancelWrite(unittest.TestCase):
self.s.write(DATA)
t2 = time.time()
self.assertEqual(self.cancel_called, 1)
- self.assertTrue(0.5 < (t2 - t1) < 2, 'Function did not return in time: {}'.format(t2 - t1))
+ self.assertTrue(0.5 < (t2 - t1) < 2.5, 'Function did not return in time: {}'.format(t2 - t1))
#~ self.assertTrue(not self.s.isOpen())
#~ self.assertRaises(serial.SerialException, self.s.open)