summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIlya Etingof <etingof@gmail.com>2018-07-05 10:38:56 +0200
committerIlya Etingof <etingof@gmail.com>2018-07-05 10:42:03 +0200
commitc950f407ea0e1404221d473da6550cba7f773fa1 (patch)
treef0909407fbb7ef2b4290d24b33139c84274ea05b
parent91fe21ab60f8da7b28f2d5f6954f11a310ff9573 (diff)
downloadpysnmp-git-c950f407ea0e1404221d473da6550cba7f773fa1.tar.gz
Fix var-bind initialization from ObjectIdentity at hlapi
-rw-r--r--CHANGES.txt4
-rw-r--r--pysnmp/hlapi/varbinds.py8
2 files changed, 7 insertions, 5 deletions
diff --git a/CHANGES.txt b/CHANGES.txt
index 64768b3d..675b6647 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -23,13 +23,15 @@ Revision 5.0.0, released 2018-07-??
methods. The goal is to let MIB objects access/modify whatever
custom Python objects they need while being called back.
-Revision 4.4.5, released 2018-04-XX
+Revision 4.4.5, released 2018-07-XX
-----------------------------------
- Fixed zero SNMPv3 boots/time values put in SNMPv3 TRAP messages
- Fixed broken InetAddressType rendering caused by a pyasn1 regression
- Fixed typo in RFC1158 module
- Fixed possible infinite loop in GETBULK response PDU builder
+- Fixed memory leak in the `config.delContext()` VACM management harness
+- Fixed var-binds initialization from `ObjectIdentity` object at `hlapi`
Revision 4.4.4, released 2018-01-03
-----------------------------------
diff --git a/pysnmp/hlapi/varbinds.py b/pysnmp/hlapi/varbinds.py
index ac9151a8..4d80a970 100644
--- a/pysnmp/hlapi/varbinds.py
+++ b/pysnmp/hlapi/varbinds.py
@@ -29,8 +29,8 @@ class CommandGeneratorVarBinds(AbstractVarBinds):
for varBind in varBinds:
if isinstance(varBind, ObjectType):
pass
- elif isinstance(varBind[0], ObjectIdentity):
- varBind = ObjectType(*varBind)
+ elif isinstance(varBind, ObjectIdentity):
+ varBind = ObjectType(varBind)
elif isinstance(varBind[0][0], tuple): # legacy
varBind = ObjectType(ObjectIdentity(varBind[0][0][0], varBind[0][0][1], *varBind[0][1:]), varBind[1])
else:
@@ -57,8 +57,8 @@ class NotificationOriginatorVarBinds(AbstractVarBinds):
for varBind in varBinds:
if isinstance(varBind, ObjectType):
pass
- elif isinstance(varBind[0], ObjectIdentity):
- varBind = ObjectType(*varBind)
+ elif isinstance(varBind, ObjectIdentity):
+ varBind = ObjectType(varBind)
else:
varBind = ObjectType(ObjectIdentity(varBind[0]), varBind[1])
__varBinds.append(varBind.resolveWithMib(mibViewController))