summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIlya Etingof <etingof@gmail.com>2019-09-24 09:48:00 +0200
committerIlya Etingof <etingof@gmail.com>2019-09-24 09:48:00 +0200
commitc5cefab2cee5ae38d093743ef83a08641385b1cc (patch)
tree0f36fc28861f59b038083c2ca228813b20192fb6
parenta9964be80f9de7b156610f7d7f2899e9073e37f9 (diff)
downloadpysnmp-git-c5cefab2cee5ae38d093743ef83a08641385b1cc.tar.gz
Fix broken SNMPv3 authoritative engine ID discovery
Fixed a regression in SNMPv3 `msgFlag` initialization on authoritative SNMP engine ID discovery. This bug causes secure communication with peer SNMP engines to stall at SNMP engine ID discovery procedure.
-rw-r--r--CHANGES.txt6
-rw-r--r--pysnmp/proto/mpmod/rfc3412.py2
-rw-r--r--pysnmp/proto/secmod/rfc3414/service.py2
3 files changed, 6 insertions, 4 deletions
diff --git a/CHANGES.txt b/CHANGES.txt
index 1a00e66d..91679c19 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,8 +1,10 @@
-Revision 4.4.12, released 2019-08-XX
+Revision 4.4.12, released 2019-09-XX
------------------------------------
-No changes yet
+- Fixed broken SNMPv3 `msgFlag` initialization on authoritative SNMP
+ engine ID discovery. This bug causes secure communication with peer
+ SNMP engines to stall at SNMP engine ID discovery procedure.
Revision 4.4.11, released 2019-08-10
------------------------------------
diff --git a/pysnmp/proto/mpmod/rfc3412.py b/pysnmp/proto/mpmod/rfc3412.py
index bfee07f9..7c4bec98 100644
--- a/pysnmp/proto/mpmod/rfc3412.py
+++ b/pysnmp/proto/mpmod/rfc3412.py
@@ -1,7 +1,7 @@
#
# This file is part of pysnmp software.
#
-# Copyright (c) 2005-2016, Ilya Etingof <ilya@glas.net>
+# Copyright (c) 2005-2019, Ilya Etingof <etingof@gmail.com>
# License: http://snmplabs.com/pysnmp/license.html
#
import sys
diff --git a/pysnmp/proto/secmod/rfc3414/service.py b/pysnmp/proto/secmod/rfc3414/service.py
index be2515ec..90a90307 100644
--- a/pysnmp/proto/secmod/rfc3414/service.py
+++ b/pysnmp/proto/secmod/rfc3414/service.py
@@ -385,7 +385,7 @@ class SnmpUSMSecurityModel(AbstractSecurityModel):
# Clear possible auth&priv flags
headerData.setComponentByPosition(
- 2, univ.OctetString(hexValue='00'), verifyConstraints=False,
+ 2, univ.OctetString(hexValue='04'), verifyConstraints=False,
matchTags=False, matchConstraints=False
)