From a57dc324309e76d0cb7673868a6f86c69d895581 Mon Sep 17 00:00:00 2001 From: Ilya Etingof Date: Tue, 24 Apr 2018 11:24:06 +0200 Subject: VACM contextName memory leak fix --- pysnmp/entity/config.py | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) (limited to 'pysnmp/entity') diff --git a/pysnmp/entity/config.py b/pysnmp/entity/config.py index ce6e9b07..2caa20f5 100644 --- a/pysnmp/entity/config.py +++ b/pysnmp/entity/config.py @@ -396,14 +396,31 @@ delSocketTransport = delTransport # VACM shortcuts -def addContext(snmpEngine, contextName): +def __cookVacmContextInfo(snmpEngine, contextName): mibBuilder = snmpEngine.msgAndPduDsp.mibInstrumController.mibBuilder - vacmContextEntry, = mibBuilder.importSymbols('SNMP-VIEW-BASED-ACM-MIB', 'vacmContextEntry') tblIdx = vacmContextEntry.getInstIdFromIndices(contextName) + return vacmContextEntry, tblIdx + + +def addContext(snmpEngine, contextName): + vacmContextEntry, tblIdx = __cookVacmContextInfo(snmpEngine, contextName) + + snmpEngine.msgAndPduDsp.mibInstrumController.writeVars( + ((vacmContextEntry.name + (5,) + tblIdx, 'destroy'),) + ) snmpEngine.msgAndPduDsp.mibInstrumController.writeVars( (vacmContextEntry.name + (1,) + tblIdx, contextName), - ** dict(snmpEngine=snmpEngine) + (vacmContextEntry.name + (2,) + tblIdx, 'createAndGo'), + **dict(snmpEngine=snmpEngine) + ) + + +def delContext(snmpEngine, contextName): + vacmContextEntry, tblIdx = __cookVacmContextInfo(snmpEngine, contextName) + + snmpEngine.msgAndPduDsp.mibInstrumController.writeVars( + ((vacmContextEntry.name + (5,) + tblIdx, 'destroy'),) ) @@ -459,7 +476,7 @@ def addVacmAccess(snmpEngine, groupName, contextName, securityModel, contextName, securityModel, securityLevel) - addContext(snmpEngine, contextName) # this is leaky + addContext(snmpEngine, contextName) snmpEngine.msgAndPduDsp.mibInstrumController.writeVars( (vacmAccessEntry.name + (9,) + tblIdx, 'destroy'), @@ -483,6 +500,9 @@ def delVacmAccess(snmpEngine, groupName, contextName, securityModel, vacmAccessEntry, tblIdx = __cookVacmAccessInfo(snmpEngine, groupName, contextName, securityModel, securityLevel) + + delContext(snmpEngine, contextName) + snmpEngine.msgAndPduDsp.mibInstrumController.writeVars( (vacmAccessEntry.name + (9,) + tblIdx, 'destroy'), **dict(snmpEngine=snmpEngine) -- cgit v1.2.1