QPID-2025: Log errors instead of printStackTracing()

git-svn-id: https://svn.apache.org/repos/asf/qpid/branches/java-network-refactor@811326 13f79535-47bb-0310-9956-ffa450edef68

2 files changed, 9 insertions, 3 deletions

diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java
index 49bdffb584..19d98161c6 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java
@@ -227,7 +227,7 @@ public class AMQProtocolEngine implements ProtocolEngine, Managable, AMQProtocol
                         }
                         catch (Exception e)
                         {
-                            e.printStackTrace();
+                            _logger.error("Unexpected exception when processing datablock", e);
                             closeProtocolSession();
                         }
                     }
@@ -236,7 +236,7 @@ public class AMQProtocolEngine implements ProtocolEngine, Managable, AMQProtocol
         }
         catch (Exception e)
         {
-            e.printStackTrace();
+            _logger.error("Unexpected exception when processing datablock", e);
             closeProtocolSession();
         }
     }
diff --git a/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java b/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java
index 477e2cd5af..8df3644929 100644
--- a/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java
+++ b/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java
@@ -30,13 +30,13 @@ import java.nio.ByteBuffer;
 
 import javax.net.ssl.SSLEngine;
 
+import org.apache.log4j.Logger;
 import org.apache.mina.common.ConnectFuture;
 import org.apache.mina.common.IdleStatus;
 import org.apache.mina.common.IoAcceptor;
 import org.apache.mina.common.IoFilterChain;
 import org.apache.mina.common.IoHandlerAdapter;
 import org.apache.mina.common.IoSession;
-import org.apache.mina.common.IoSessionConfig;
 import org.apache.mina.common.SimpleByteBufferAllocator;
 import org.apache.mina.common.WriteFuture;
 import org.apache.mina.filter.ReadThrottleFilterBuilder;
@@ -80,6 +80,8 @@ public class MINANetworkDriver extends IoHandlerAdapter implements NetworkDriver
 
     private WriteFuture _lastWriteFuture;
 
+    private static final Logger _logger = Logger.getLogger(MINANetworkDriver.class);
+    
     public MINANetworkDriver(boolean useNIO, int processors, boolean executorPool, boolean protectIO)
     {
         _useNIO = useNIO;
@@ -289,6 +291,10 @@ public class MINANetworkDriver extends IoHandlerAdapter implements NetworkDriver
         if (_protocolEngine != null)
         {
             _protocolEngine.exception(throwable);
+        } 
+        else
+        {
+            _logger.error("Exception thrown and no ProtocolEngine to handle it", throwable);
         }
         _lastException = throwable;
     }