summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Ritchie <ritchiem@apache.org>2008-08-21 13:15:25 +0000
committerMartin Ritchie <ritchiem@apache.org>2008-08-21 13:15:25 +0000
commitdeddc77062722283a69ab1beb64172bb5be1a07a (patch)
tree147864e99ada72b69b53951ddd0967ed9d132985
parenta5a0b9aa8eceef05a018e8ab1df34044854845de (diff)
downloadqpid-python-deddc77062722283a69ab1beb64172bb5be1a07a.tar.gz
Stopped the broker closing the ProtocolSessions as this was causing the client to lock in Mina seemingly missing the notify for the CloseFuture and hangs indefinately
git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk@687741 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java9
1 files changed, 5 insertions, 4 deletions
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
index 64914b407d..aec032bb54 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
@@ -230,7 +230,8 @@ public class AMQMinaProtocolSession implements AMQProtocolSession, Managable
_logger.info("Channel[" + channelId + "] awaiting closure. Should close socket as client did not close-ok :" + frame);
}
- closeProtocolSession();
+
+// closeProtocolSession();
return;
}
}
@@ -272,7 +273,7 @@ public class AMQMinaProtocolSession implements AMQProtocolSession, Managable
}
catch (AMQException e)
{
- _logger.error("Received incorrect protocol initiation", e);
+ _logger.info("Received incorrect protocol initiation:" + e.getMessage());
_minaProtocolSession.write(new ProtocolInitiation(ProtocolVersion.getLatestSupportedVersion()));
@@ -356,7 +357,7 @@ public class AMQMinaProtocolSession implements AMQProtocolSession, Managable
_logger.error("Unexpected exception while processing frame. Closing connection.", e);
- closeProtocolSession();
+// closeProtocolSession();
}
}
@@ -655,9 +656,9 @@ public class AMQMinaProtocolSession implements AMQProtocolSession, Managable
public void closeProtocolSession(boolean waitLast)
{
- _logger.debug("Waiting for last write to join.");
if (waitLast && (_lastWriteFuture != null))
{
+ _logger.debug("Waiting for last write to join.");
_lastWriteFuture.join(LAST_WRITE_FUTURE_JOIN_TIMEOUT);
}