summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Godfrey <rgodfrey@apache.org>2012-02-20 16:36:24 +0000
committerRobert Godfrey <rgodfrey@apache.org>2012-02-20 16:36:24 +0000
commit2c72dcf28d5e4421c1190446519ee7094f7e54de (patch)
tree401302d5ecfe3760965ff0bf16962af3bcf8449a
parent9db2f9d8fb6024989abce4859dda352aec8389c1 (diff)
downloadqpid-python-2c72dcf28d5e4421c1190446519ee7094f7e54de.tar.gz
QPID-3095 : AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@1291353 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java b/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java
index 771e80c3bc..987404cb80 100644
--- a/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java
+++ b/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java
@@ -319,18 +319,18 @@ public class AMQBrokerDetails implements BrokerDetails
BrokerDetails bd = (BrokerDetails) o;
- return _host.equalsIgnoreCase(bd.getHost()) &&
+ return _host.toLowerCase().equals(bd.getHost() == null ? null : bd.getHost().toLowerCase()) &&
(_port == bd.getPort()) &&
- _transport.equalsIgnoreCase(bd.getTransport());
+ _transport.toLowerCase().equals(bd.getTransport() == null ? null : bd.getTransport().toLowerCase());
//TODO do we need to compare all the options as well?
}
@Override
public int hashCode()
{
- int result = _host != null ? _host.hashCode() : 0;
+ int result = _host != null ? _host.toLowerCase().hashCode() : 0;
result = 31 * result + _port;
- result = 31 * result + (_transport != null ? _transport.hashCode() : 0);
+ result = 31 * result + (_transport != null ? _transport.toLowerCase().hashCode() : 0);
return result;
}