summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Rudyy <orudyy@apache.org>2013-03-13 12:54:21 +0000
committerAlex Rudyy <orudyy@apache.org>2013-03-13 12:54:21 +0000
commit50b01b5ffd0f7f072543c624d28533263b4ee851 (patch)
treeb3dfaaa72846889941670903f96cb6468c29cbc5
parent8445629c4ec4efa8703d5ed50397841fdd0c9bbe (diff)
downloadqpid-python-50b01b5ffd0f7f072543c624d28533263b4ee851.tar.gz
QPID-4596,QPID-4638: Change authentication provider names to shorter names, rename Port#AUTHENTICATION_MANAGER into Port#AUTHENTICATION_PROVIDER
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1455919 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/util.js2
-rw-r--r--qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/AuthenticationProvider.js2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/configuration/startup/BrokerRecoverer.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/model/Port.java8
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/AuthenticationProviderAdapter.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/BrokerAdapter.java18
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/PortAdapter.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/AnonymousAuthenticationManagerFactory.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/Base64MD5PasswordFileAuthenticationManagerFactory.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationManagerFactory.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/KerberosAuthenticationManagerFactory.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/PlainPasswordFileAuthenticationManagerFactory.java2
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/SimpleLDAPAuthenticationManagerFactory.java2
-rw-r--r--qpid/java/broker/src/main/resources/initial-store.json2
-rw-r--r--qpid/java/broker/src/test/java/org/apache/qpid/server/configuration/startup/BrokerRecovererTest.java2
-rw-r--r--qpid/java/systests/etc/config-systests.json2
-rw-r--r--qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationTest.java2
-rw-r--r--qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/MultipleAuthenticationManagersTest.java2
-rw-r--r--qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/Asserts.java4
-rw-r--r--qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/AuthenticationProviderRestTest.java2
-rw-r--r--qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/PortRestTest.java4
21 files changed, 32 insertions, 36 deletions
diff --git a/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/util.js b/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/util.js
index e7554e6d9f..b20169c94d 100644
--- a/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/util.js
+++ b/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/util.js
@@ -119,7 +119,7 @@ define(["dojo/_base/xhr"],
util.isProviderManagingUsers = function(type)
{
- return (type === "PlainPasswordFileAuthenticationProvider" || type === "Base64MD5PasswordFileAuthenticationProvider");
+ return (type === "PlainPasswordFile" || type === "Base64MD5PasswordFile");
};
return util;
diff --git a/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/AuthenticationProvider.js b/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/AuthenticationProvider.js
index 0d97eb3a07..b7c0554158 100644
--- a/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/AuthenticationProvider.js
+++ b/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/AuthenticationProvider.js
@@ -135,7 +135,7 @@ define(["dojo/_base/xhr",
var editButton = query(".editAuthenticationProviderButton", node)[0];
var editWidget = registry.byNode(editButton);
- var hideEdit = (that.authProviderData.type === 'AnonymousAuthenticationManager' || that.authProviderData.type === 'ExternalAuthenticationManager')
+ var hideEdit = (that.authProviderData.type === 'Anonymous' || that.authProviderData.type === 'External' || that.authProviderData.type === 'Kerberos')
domStyle.set(editWidget.domNode, "display", hideEdit ? "none": "");
if (util.isProviderManagingUsers(that.authProviderData.type))
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/configuration/startup/BrokerRecoverer.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/configuration/startup/BrokerRecoverer.java
index 48d80592f6..3d19e781e2 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/configuration/startup/BrokerRecoverer.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/configuration/startup/BrokerRecoverer.java
@@ -112,7 +112,7 @@ public class BrokerRecoverer implements ConfiguredObjectRecoverer<Broker>
Collection<Port> ports = broker.getPorts();
for (Port port : ports)
{
- String authenticationProviderName = (String) port.getAttribute(Port.AUTHENTICATION_MANAGER);
+ String authenticationProviderName = (String) port.getAttribute(Port.AUTHENTICATION_PROVIDER);
AuthenticationProvider provider = null;
if (authenticationProviderName != null)
{
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/Port.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/Port.java
index 2f94c3cab7..33ba34767d 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/Port.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/Port.java
@@ -44,11 +44,7 @@ public interface Port extends ConfiguredObject
String RECEIVE_BUFFER_SIZE = "receiveBufferSize";
String NEED_CLIENT_AUTH = "needClientAuth";
String WANT_CLIENT_AUTH = "wantClientAuth";
-
- /**
- * TODO: rename it to AUTHENTICATION_MANAGER_ID or introduce relationships
- */
- String AUTHENTICATION_MANAGER = "authenticationManager";
+ String AUTHENTICATION_PROVIDER = "authenticationProvider";
// Attributes
public static final Collection<String> AVAILABLE_ATTRIBUTES =
@@ -71,7 +67,7 @@ public interface Port extends ConfiguredObject
RECEIVE_BUFFER_SIZE,
NEED_CLIENT_AUTH,
WANT_CLIENT_AUTH,
- AUTHENTICATION_MANAGER
+ AUTHENTICATION_PROVIDER
));
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/AuthenticationProviderAdapter.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/AuthenticationProviderAdapter.java
index d77b58458a..16c6cb7e5e 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/AuthenticationProviderAdapter.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/AuthenticationProviderAdapter.java
@@ -217,7 +217,7 @@ public abstract class AuthenticationProviderAdapter<T extends AuthenticationMana
Collection<Port> ports = new ArrayList<Port>(_broker.getPorts());
for (Port port : ports)
{
- if (providerName.equals(port.getAttribute(Port.AUTHENTICATION_MANAGER)))
+ if (providerName.equals(port.getAttribute(Port.AUTHENTICATION_PROVIDER)))
{
throw new IntegrityViolationException("Authentication provider '" + providerName + "' is set on port " + port.getName());
}
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/BrokerAdapter.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/BrokerAdapter.java
index 628ba5a099..291f751a5c 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/BrokerAdapter.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/BrokerAdapter.java
@@ -462,21 +462,21 @@ public class BrokerAdapter extends AbstractAdapter implements Broker, Configurat
private AuthenticationProvider createAuthenticationProvider(Map<String, Object> attributes)
{
- String type = (String)attributes.get(AuthenticationProvider.TYPE);
- if (type == null)
- {
- throw new IllegalConfigurationException("Authentication provider type is not specified");
- }
-
AuthenticationProvider authenticationProvider = null;
synchronized (_authenticationProviders)
{
+ String type = (String)attributes.get(AuthenticationProvider.TYPE);
+ if (type == null)
+ {
+ throw new IllegalConfigurationException("Authentication provider type is not specified");
+ }
+
// a temporary restriction to prevent creation of several instances
// of PlainPasswordFileAuthenticationProvider/Base64MD5PasswordFileAuthenticationProvider
// due to current limitation of JMX management which cannot cope
- // with several user management MBeans as MBEan type is used as a name.
+ // with several user management MBeans as MBean type is used as a name.
- // TODO: Remove this check after fixing the JMX management
+ // TODO: Remove this check after fixing of JMX management
if (type.equals(PlainPasswordFileAuthenticationManagerFactory.PROVIDER_TYPE)
|| type.equals(Base64MD5PasswordFileAuthenticationManagerFactory.PROVIDER_TYPE))
{
@@ -487,7 +487,7 @@ public class BrokerAdapter extends AbstractAdapter implements Broker, Configurat
if (providerType.equals(PlainPasswordFileAuthenticationManagerFactory.PROVIDER_TYPE)
|| providerType.equals(Base64MD5PasswordFileAuthenticationManagerFactory.PROVIDER_TYPE))
{
- throw new IllegalConfigurationException("Authentication provider managing users alredy exists ["
+ throw new IllegalConfigurationException("An authentication provider which can manage users alredy exists ["
+ provider.getName() + "]. Only one instance is allowed.");
}
}
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/PortAdapter.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/PortAdapter.java
index 298ff05dd1..c3d2c3d791 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/PortAdapter.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/PortAdapter.java
@@ -63,7 +63,7 @@ public class PortAdapter extends AbstractAdapter implements Port
put(WANT_CLIENT_AUTH, Boolean.class);
put(BINDING_ADDRESS, String.class);
put(STATE, State.class);
- put(AUTHENTICATION_MANAGER, String.class);
+ put(AUTHENTICATION_PROVIDER, String.class);
}});
private final Broker _broker;
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/AnonymousAuthenticationManagerFactory.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/AnonymousAuthenticationManagerFactory.java
index 0c6aa75636..91aba71720 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/AnonymousAuthenticationManagerFactory.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/AnonymousAuthenticationManagerFactory.java
@@ -27,7 +27,7 @@ import org.apache.qpid.server.plugin.AuthenticationManagerFactory;
public class AnonymousAuthenticationManagerFactory implements AuthenticationManagerFactory
{
- public static final String PROVIDER_TYPE = AnonymousAuthenticationManager.class.getSimpleName();
+ public static final String PROVIDER_TYPE = "Anonymous";
@Override
public AuthenticationManager createInstance(Map<String, Object> attributes)
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/Base64MD5PasswordFileAuthenticationManagerFactory.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/Base64MD5PasswordFileAuthenticationManagerFactory.java
index c0c0b8e3c1..8b979c324d 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/Base64MD5PasswordFileAuthenticationManagerFactory.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/Base64MD5PasswordFileAuthenticationManagerFactory.java
@@ -28,7 +28,7 @@ import org.apache.qpid.server.util.ResourceBundleLoader;
public class Base64MD5PasswordFileAuthenticationManagerFactory extends AbstractPrincipalDatabaseAuthManagerFactory
{
- public static final String PROVIDER_TYPE = "Base64MD5PasswordFileAuthenticationProvider";
+ public static final String PROVIDER_TYPE = "Base64MD5PasswordFile";
@Override
public String getType()
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationManagerFactory.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationManagerFactory.java
index 29cfb2ad29..64acfafc4a 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationManagerFactory.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationManagerFactory.java
@@ -27,7 +27,7 @@ import org.apache.qpid.server.plugin.AuthenticationManagerFactory;
public class ExternalAuthenticationManagerFactory implements AuthenticationManagerFactory
{
- public static final String PROVIDER_TYPE = ExternalAuthenticationManager.class.getSimpleName();
+ public static final String PROVIDER_TYPE = "External";
@Override
public AuthenticationManager createInstance(Map<String, Object> attributes)
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/KerberosAuthenticationManagerFactory.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/KerberosAuthenticationManagerFactory.java
index e60f37a18e..a2d5bd4c8e 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/KerberosAuthenticationManagerFactory.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/KerberosAuthenticationManagerFactory.java
@@ -27,7 +27,7 @@ import org.apache.qpid.server.plugin.AuthenticationManagerFactory;
public class KerberosAuthenticationManagerFactory implements AuthenticationManagerFactory
{
- public static final String PROVIDER_TYPE = KerberosAuthenticationManager.class.getSimpleName();
+ public static final String PROVIDER_TYPE = "Kerberos";
@Override
public AuthenticationManager createInstance(Map<String, Object> attributes)
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/PlainPasswordFileAuthenticationManagerFactory.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/PlainPasswordFileAuthenticationManagerFactory.java
index c08b00f907..5e077cfe79 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/PlainPasswordFileAuthenticationManagerFactory.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/PlainPasswordFileAuthenticationManagerFactory.java
@@ -28,7 +28,7 @@ import org.apache.qpid.server.util.ResourceBundleLoader;
public class PlainPasswordFileAuthenticationManagerFactory extends AbstractPrincipalDatabaseAuthManagerFactory
{
- public static final String PROVIDER_TYPE = "PlainPasswordFileAuthenticationProvider";
+ public static final String PROVIDER_TYPE = "PlainPasswordFile";
@Override
public String getType()
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/SimpleLDAPAuthenticationManagerFactory.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/SimpleLDAPAuthenticationManagerFactory.java
index ff468dc56a..d1f2e9b3ee 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/SimpleLDAPAuthenticationManagerFactory.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/SimpleLDAPAuthenticationManagerFactory.java
@@ -32,7 +32,7 @@ public class SimpleLDAPAuthenticationManagerFactory implements AuthenticationMan
public static final String RESOURCE_BUNDLE = "org.apache.qpid.server.security.auth.manager.SimpleLDAPAuthenticationProviderAttributeDescriptions";
private static final String DEFAULT_LDAP_CONTEXT_FACTORY = "com.sun.jndi.ldap.LdapCtxFactory";
- public static final String PROVIDER_TYPE = SimpleLDAPAuthenticationManager.class.getSimpleName();
+ public static final String PROVIDER_TYPE = "SimpleLDAP";
public static final String ATTRIBUTE_LDAP_CONTEXT_FACTORY = "ldapContextFactory";
public static final String ATTRIBUTE_SEARCH_FILTER = "searchFilter";
diff --git a/qpid/java/broker/src/main/resources/initial-store.json b/qpid/java/broker/src/main/resources/initial-store.json
index 8e278120fc..9fe72b3601 100644
--- a/qpid/java/broker/src/main/resources/initial-store.json
+++ b/qpid/java/broker/src/main/resources/initial-store.json
@@ -24,7 +24,7 @@
"defaultVirtualHost" : "default",
"authenticationproviders" : [ {
"name" : "passwordFile",
- "type" : "PlainPasswordFileAuthenticationProvider",
+ "type" : "PlainPasswordFile",
"path" : "${QPID_HOME}/etc/passwd"
} ],
"ports" : [ {
diff --git a/qpid/java/broker/src/test/java/org/apache/qpid/server/configuration/startup/BrokerRecovererTest.java b/qpid/java/broker/src/test/java/org/apache/qpid/server/configuration/startup/BrokerRecovererTest.java
index 883f88cc36..8e0bfdaeb7 100644
--- a/qpid/java/broker/src/test/java/org/apache/qpid/server/configuration/startup/BrokerRecovererTest.java
+++ b/qpid/java/broker/src/test/java/org/apache/qpid/server/configuration/startup/BrokerRecovererTest.java
@@ -245,7 +245,7 @@ public class BrokerRecovererTest extends TestCase
Port port1 = mock(Port.class);
when(port1.getName()).thenReturn("port1");
when(port1.getPort()).thenReturn(5671);
- when(port1.getAttribute(Port.AUTHENTICATION_MANAGER)).thenReturn("authenticationProvider1");
+ when(port1.getAttribute(Port.AUTHENTICATION_PROVIDER)).thenReturn("authenticationProvider1");
ConfigurationEntry portEntry2 = mock(ConfigurationEntry.class);
Port port2 = mock(Port.class);
when(port2.getName()).thenReturn("port2");
diff --git a/qpid/java/systests/etc/config-systests.json b/qpid/java/systests/etc/config-systests.json
index 412bee3f6b..36e6f61d43 100644
--- a/qpid/java/systests/etc/config-systests.json
+++ b/qpid/java/systests/etc/config-systests.json
@@ -28,7 +28,7 @@
"trustStorePassword": "password",
"authenticationproviders" : [ {
"name" : "plain",
- "type" : "PlainPasswordFileAuthenticationProvider",
+ "type" : "PlainPasswordFile",
"path" : "${QPID_HOME}/etc/passwd"
} ],
"ports" : [ {
diff --git a/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationTest.java b/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationTest.java
index c7a43a292b..b90f56daf6 100644
--- a/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationTest.java
+++ b/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/ExternalAuthenticationTest.java
@@ -57,7 +57,7 @@ public class ExternalAuthenticationTest extends QpidBrokerTestCase
public void testExternalAuthenticationManagerOnSSLPort() throws Exception
{
setCommonBrokerSSLProperties(true);
- getBrokerConfiguration().setObjectAttribute(TestBrokerConfiguration.ENTRY_NAME_SSL_PORT, Port.AUTHENTICATION_MANAGER, TestBrokerConfiguration.ENTRY_NAME_EXTERNAL_PROVIDER);
+ getBrokerConfiguration().setObjectAttribute(TestBrokerConfiguration.ENTRY_NAME_SSL_PORT, Port.AUTHENTICATION_PROVIDER, TestBrokerConfiguration.ENTRY_NAME_EXTERNAL_PROVIDER);
super.setUp();
setClientKeystoreProperties();
diff --git a/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/MultipleAuthenticationManagersTest.java b/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/MultipleAuthenticationManagersTest.java
index f41f1159ab..40346d7424 100644
--- a/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/MultipleAuthenticationManagersTest.java
+++ b/qpid/java/systests/src/main/java/org/apache/qpid/server/security/auth/manager/MultipleAuthenticationManagersTest.java
@@ -56,7 +56,7 @@ public class MultipleAuthenticationManagersTest extends QpidBrokerTestCase
sslPortAttributes.put(Port.TRANSPORTS, Collections.singleton(Transport.SSL));
sslPortAttributes.put(Port.PORT, DEFAULT_SSL_PORT);
sslPortAttributes.put(Port.NAME, TestBrokerConfiguration.ENTRY_NAME_SSL_PORT);
- sslPortAttributes.put(Port.AUTHENTICATION_MANAGER, TestBrokerConfiguration.ENTRY_NAME_ANONYMOUS_PROVIDER);
+ sslPortAttributes.put(Port.AUTHENTICATION_PROVIDER, TestBrokerConfiguration.ENTRY_NAME_ANONYMOUS_PROVIDER);
config.addPortConfiguration(sslPortAttributes);
// set the ssl system properties
diff --git a/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/Asserts.java b/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/Asserts.java
index 16253139ce..05c3b538d9 100644
--- a/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/Asserts.java
+++ b/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/Asserts.java
@@ -203,12 +203,12 @@ public class Asserts
}
if (isAMQPPort)
{
- assertAttributesPresent(port, Port.AVAILABLE_ATTRIBUTES, Port.CREATED, Port.UPDATED, Port.AUTHENTICATION_MANAGER);
+ assertAttributesPresent(port, Port.AVAILABLE_ATTRIBUTES, Port.CREATED, Port.UPDATED, Port.AUTHENTICATION_PROVIDER);
assertNotNull("Unexpected value of attribute " + Port.BINDING_ADDRESS, port.get(Port.BINDING_ADDRESS));
}
else
{
- assertAttributesPresent(port, Port.AVAILABLE_ATTRIBUTES, Port.CREATED, Port.UPDATED, Port.AUTHENTICATION_MANAGER,
+ assertAttributesPresent(port, Port.AVAILABLE_ATTRIBUTES, Port.CREATED, Port.UPDATED, Port.AUTHENTICATION_PROVIDER,
Port.BINDING_ADDRESS, Port.TCP_NO_DELAY, Port.SEND_BUFFER_SIZE, Port.RECEIVE_BUFFER_SIZE,
Port.NEED_CLIENT_AUTH, Port.WANT_CLIENT_AUTH);
}
diff --git a/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/AuthenticationProviderRestTest.java b/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/AuthenticationProviderRestTest.java
index 40a1c13718..078a1bb483 100644
--- a/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/AuthenticationProviderRestTest.java
+++ b/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/AuthenticationProviderRestTest.java
@@ -111,7 +111,7 @@ public class AuthenticationProviderRestTest extends QpidRestTestCase
String portName = "test-port";
Map<String, Object> portAttributes = new HashMap<String, Object>();
portAttributes.put(Port.NAME, portName);
- portAttributes.put(Port.AUTHENTICATION_MANAGER, providerName);
+ portAttributes.put(Port.AUTHENTICATION_PROVIDER, providerName);
portAttributes.put(Port.PORT, findFreePort());
responseCode = getRestTestHelper().submitRequest("/rest/port/" + portName, "PUT", portAttributes);
diff --git a/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/PortRestTest.java b/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/PortRestTest.java
index 48fd8f44b1..a9b6657dbd 100644
--- a/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/PortRestTest.java
+++ b/qpid/java/systests/src/main/java/org/apache/qpid/systest/rest/PortRestTest.java
@@ -141,7 +141,7 @@ public class PortRestTest extends QpidRestTestCase
assertEquals("Unexpected response code for authentication provider creation", 201, responseCode);
attributes = new HashMap<String, Object>(port);
- attributes.put(Port.AUTHENTICATION_MANAGER, TestBrokerConfiguration.ENTRY_NAME_ANONYMOUS_PROVIDER);
+ attributes.put(Port.AUTHENTICATION_PROVIDER, TestBrokerConfiguration.ENTRY_NAME_ANONYMOUS_PROVIDER);
attributes.put(Port.PROTOCOLS, Collections.singleton(Protocol.AMQP_0_9_1));
responseCode = getRestTestHelper().submitRequest("/rest/port/" + portName, "PUT", attributes);
@@ -152,7 +152,7 @@ public class PortRestTest extends QpidRestTestCase
assertEquals("Unexpected number of ports with name " + portName, 1, portDetails.size());
port = portDetails.get(0);
- assertEquals("Unexpected authentication provider", TestBrokerConfiguration.ENTRY_NAME_ANONYMOUS_PROVIDER, port.get(Port.AUTHENTICATION_MANAGER));
+ assertEquals("Unexpected authentication provider", TestBrokerConfiguration.ENTRY_NAME_ANONYMOUS_PROVIDER, port.get(Port.AUTHENTICATION_PROVIDER));
Object protocols = port.get(Port.PROTOCOLS);
assertNotNull("Protocols attribute is not found", protocols);
assertTrue("Protocol attribute value is not collection:" + protocols, protocols instanceof Collection);