summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Ritchie <ritchiem@apache.org>2006-12-19 16:09:39 +0000
committerMartin Ritchie <ritchiem@apache.org>2006-12-19 16:09:39 +0000
commitdaf5e34ea42702c102df5363284b2e3e5ef4e192 (patch)
tree1539dae59746ce957406d702e9e85d69fb97a9a6
parent3085b02021e10aefd23de281f1ae71189a3c2ac8 (diff)
downloadqpid-python-daf5e34ea42702c102df5363284b2e3e5ef4e192.tar.gz
Maven output clean up.
Mainly removed exception stack traces from expected exceptions. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@488713 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--java/broker/src/main/java/org/apache/qpid/server/util/CircularBuffer.java9
-rw-r--r--java/client/src/test/java/org/apache/qpid/test/unit/basic/PropertyValueTest.java10
-rw-r--r--java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/ChannelCloseOkTest.java4
-rw-r--r--java/common/src/main/java/org/apache/qpid/framing/PropertyFieldTable.java4
4 files changed, 16 insertions, 11 deletions
diff --git a/java/broker/src/main/java/org/apache/qpid/server/util/CircularBuffer.java b/java/broker/src/main/java/org/apache/qpid/server/util/CircularBuffer.java
index 4767844abe..b58d551226 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/util/CircularBuffer.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/util/CircularBuffer.java
@@ -20,10 +20,15 @@
*/
package org.apache.qpid.server.util;
+import org.apache.log4j.Logger;
+
import java.util.Iterator;
public class CircularBuffer implements Iterable
{
+
+ private static final Logger _logger = Logger.getLogger(CircularBuffer.class);
+
private final Object[] _log;
private int _size;
private int _index;
@@ -102,7 +107,7 @@ public class CircularBuffer implements Iterable
{
for(Object o : this)
{
- System.out.println(o);
+ _logger.info(o);
}
}
@@ -120,7 +125,7 @@ public class CircularBuffer implements Iterable
for(String s : items)
{
buffer.add(s);
- System.out.println(buffer);
+ _logger.info(buffer);
}
}
}
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/basic/PropertyValueTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/basic/PropertyValueTest.java
index 7f76baa157..17679788bd 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/basic/PropertyValueTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/basic/PropertyValueTest.java
@@ -116,7 +116,9 @@ public class PropertyValueTest extends TestCase implements MessageListener
m.setIntProperty("Int", (int) Integer.MAX_VALUE);
m.setJMSCorrelationID("Correlation");
- m.setJMSPriority(100);
+ //fixme the m.setJMSMessage has no effect
+ producer.setPriority(8);
+ m.setJMSPriority(3);
// Queue
Queue q;
@@ -182,10 +184,8 @@ public class PropertyValueTest extends TestCase implements MessageListener
(int) Integer.MAX_VALUE, m.getIntProperty("Int"));
Assert.assertEquals("Check CorrelationID properties are correctly transported",
"Correlation", m.getJMSCorrelationID());
-
- _logger.warn("getJMSPriority not being verified.");
-// Assert.assertEquals("Check Priority properties are correctly transported",
-// 100, m.getJMSPriority());
+ Assert.assertEquals("Check Priority properties are correctly transported",
+ 8, m.getJMSPriority());
// Queue
Assert.assertEquals("Check ReplyTo properties are correctly transported",
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/ChannelCloseOkTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/ChannelCloseOkTest.java
index 7d4c2d06d3..ac789eb915 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/ChannelCloseOkTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/ChannelCloseOkTest.java
@@ -121,7 +121,7 @@ public class ChannelCloseOkTest extends TestCase
{
if (_connection != null)
{
- System.out.println(">>>>>>>>>>>>>>.. closing");
+ _log.info(">>>>>>>>>>>>>>.. closing");
_connection.close();
}
}
@@ -137,7 +137,7 @@ public class ChannelCloseOkTest extends TestCase
{
public void onException(JMSException jmsException)
{
- _log.error("onException - ", jmsException);
+ _log.warn("onException - "+jmsException.getMessage());
}
});
diff --git a/java/common/src/main/java/org/apache/qpid/framing/PropertyFieldTable.java b/java/common/src/main/java/org/apache/qpid/framing/PropertyFieldTable.java
index 83cd204ca9..4b8f56e4e8 100644
--- a/java/common/src/main/java/org/apache/qpid/framing/PropertyFieldTable.java
+++ b/java/common/src/main/java/org/apache/qpid/framing/PropertyFieldTable.java
@@ -129,7 +129,7 @@ public class PropertyFieldTable implements FieldTable
}
catch (Exception e)
{
- _logger.warn("Unable to decode PropertyFieldTable format:" + textFormat, e);
+ _logger.warn("Unable to decode PropertyFieldTable format:" + textFormat);
throw new IllegalArgumentException("Unable to decode PropertyFieldTable format:" + textFormat);
}
}
@@ -607,7 +607,7 @@ public class PropertyFieldTable implements FieldTable
if (!(Character.isLetter(propertyName.charAt(0))
|| propertyName.charAt(0) == '$'
|| propertyName.charAt(0) == '#'
- || propertyName.charAt(0) == '_')) // Not official AMQP added for JMS.
+ || propertyName.charAt(0) == '_')) // Not official AMQP added for JMS.
{
throw new IllegalArgumentException("Identifier '" + propertyName + "' does not start with a valid AMQP start character");
}