clean up warnings about unused variables

Remove all warnings in common, broker, client, and systests regarding
unused variables, as indicated by Eclipse builds.


git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@488450 13f79535-47bb-0310-9956-ffa450edef68

13 files changed, 13 insertions, 37 deletions

diff --git a/java/broker/src/main/java/org/apache/qpid/server/Main.java b/java/broker/src/main/java/org/apache/qpid/server/Main.java
index 3470a5bb08..553aecc217 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/Main.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/Main.java
@@ -522,10 +522,10 @@ public class Main implements ProtocolVersionList
          */
         public void unregisterExchange(String exchangeName) throws JMException
         {
-            boolean inUse = false;
             // TODO
             // Check if the exchange is in use.
-            // Check if there are queue-bindings with the exchnage and unregister
+        	// boolean inUse = false;
+            // Check if there are queue-bindings with the exchange and unregister
             // when there are no bindings.
             try
             {
diff --git a/java/broker/src/main/java/org/apache/qpid/server/management/MBeanIntrospector.java b/java/broker/src/main/java/org/apache/qpid/server/management/MBeanIntrospector.java
index b8235a0808..535122efb5 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/management/MBeanIntrospector.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/management/MBeanIntrospector.java
@@ -61,7 +61,6 @@ class MBeanIntrospector {
          */
         for (Method method : interfaceClass.getMethods())
         {
-            int    argCount = method.getParameterTypes().length;
             String name = method.getName();
             Class<?>  resultType = method.getReturnType();
             MBeanAttributeInfo attributeInfo = null;
diff --git a/java/broker/src/main/java/org/apache/qpid/server/security/auth/plain/PlainSaslServer.java b/java/broker/src/main/java/org/apache/qpid/server/security/auth/plain/PlainSaslServer.java
index fdf655c2d9..7f51260e45 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/security/auth/plain/PlainSaslServer.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/security/auth/plain/PlainSaslServer.java
@@ -62,7 +62,7 @@ public class PlainSaslServer implements SaslServer
             }
 
             // we do not currently support authcid in any meaningful way
-            String authcid = new String(response, 0, authzidNullPosition, "utf8");
+            // String authcid = new String(response, 0, authzidNullPosition, "utf8");
             String authzid = new String(response, authzidNullPosition + 1, authcidNullPosition - 1, "utf8");
 
             // we do not care about the prompt but it throws if null
diff --git a/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionOpenOkMethodHandler.java b/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionOpenOkMethodHandler.java
index 8785e7d44e..b5001a6e64 100644
--- a/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionOpenOkMethodHandler.java
+++ b/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionOpenOkMethodHandler.java
@@ -20,20 +20,14 @@
  */
 package org.apache.qpid.client.handler;
 
-import org.apache.log4j.Logger;
 import org.apache.qpid.AMQException;
 import org.apache.qpid.client.protocol.AMQMethodEvent;
-import org.apache.qpid.client.protocol.AMQProtocolSession;
 import org.apache.qpid.client.state.AMQState;
 import org.apache.qpid.client.state.AMQStateManager;
 import org.apache.qpid.client.state.StateAwareMethodListener;
-import org.apache.qpid.framing.ConnectionOpenOkBody;
 
 public class ConnectionOpenOkMethodHandler implements StateAwareMethodListener
 {
-
-    private static final Logger _logger = Logger.getLogger(ConnectionOpenOkMethodHandler.class);
-
     private static final ConnectionOpenOkMethodHandler _instance = new ConnectionOpenOkMethodHandler();
 
     public static ConnectionOpenOkMethodHandler getInstance()
@@ -47,8 +41,6 @@ public class ConnectionOpenOkMethodHandler implements StateAwareMethodListener
 
     public void methodReceived(AMQStateManager stateManager, AMQMethodEvent evt) throws AMQException
     {
-        AMQProtocolSession session = evt.getProtocolSession();
-        ConnectionOpenOkBody method = (ConnectionOpenOkBody) evt.getMethod();        
         stateManager.changeState(AMQState.CONNECTION_OPEN);
     }
 
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/ack/RecoverTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/ack/RecoverTest.java
index 9f31f7f010..d12ab01bdc 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/ack/RecoverTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/ack/RecoverTest.java
@@ -127,7 +127,7 @@ public class RecoverTest extends TestCase
         _logger.info("Starting connection");
         con.start();
         TextMessage tm = (TextMessage) consumer.receive();
-        TextMessage tm2 = (TextMessage) consumer.receive();
+        consumer.receive();
         tm.acknowledge();
         _logger.info("Received 2 messages, acknowledge() first message, should acknowledge both");
 
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/basic/MultipleConnectionTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/basic/MultipleConnectionTest.java
index c88024f39f..1e9de221d4 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/basic/MultipleConnectionTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/basic/MultipleConnectionTest.java
@@ -31,7 +31,7 @@ import javax.jms.*;
 public class MultipleConnectionTest extends TestCase
 {
     public static final String _defaultBroker = "vm://:1";
-    public static String _connectionString = _defaultBroker;
+    public String _connectionString = _defaultBroker;
 
     private static class Receiver
     {
@@ -176,9 +176,6 @@ public class MultipleConnectionTest extends TestCase
     {
         String broker = argv.length > 0 ? argv[0] : _defaultBroker;
 
-        int connections = 7;
-        int sessions = 2;
-
         MultipleConnectionTest test = new MultipleConnectionTest();
         test._connectionString = broker;
         test.test();
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/CloseWithBlockingReceiveTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/CloseWithBlockingReceiveTest.java
index de517459df..0b3ed931f8 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/CloseWithBlockingReceiveTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/client/channelclose/CloseWithBlockingReceiveTest.java
@@ -25,7 +25,6 @@ import org.apache.qpid.client.transport.TransportConnection;
 import javax.jms.Connection;
 import javax.jms.Session;
 import javax.jms.MessageConsumer;
-import javax.jms.Message;
 
 /**
  * @author Apache Software Foundation
@@ -72,7 +71,7 @@ public class CloseWithBlockingReceiveTest extends TestCase
         };
         long startTime = System.currentTimeMillis();
         new Thread(r).start();
-        Message m = consumer.receive(10000);
+        consumer.receive(10000);
         assertTrue(System.currentTimeMillis() - startTime < 10000);
     }
 
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/client/connection/ConnectionTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/client/connection/ConnectionTest.java
index 0da4147351..c5aa62032c 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/client/connection/ConnectionTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/client/connection/ConnectionTest.java
@@ -54,8 +54,7 @@ public class ConnectionTest extends TestCase
     {
         try
         {
-            Connection connection = new AMQConnection(_broker, "guest", "guest",
-                                                      "fred", "/test");
+            new AMQConnection(_broker, "guest", "guest", "fred", "/test");
         }
         catch (Exception e)
         {
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/client/message/MapMessageTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/client/message/MapMessageTest.java
index bd4b3b3987..cddd73898d 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/client/message/MapMessageTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/client/message/MapMessageTest.java
@@ -108,7 +108,7 @@ public class MapMessageTest extends TestCase
             JMSMapMessage mm = TestMessageHelper.newJMSMapMessage();
 
             mm.setString("value", null);
-            char c = mm.getChar("value");
+            mm.getChar("value");
             fail("Expected NullPointerException");
 
         }
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/message/StreamMessageTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/message/StreamMessageTest.java
index 315ba6ae4c..83969822c4 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/message/StreamMessageTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/message/StreamMessageTest.java
@@ -89,10 +89,10 @@ public class StreamMessageTest extends TestCase
 
         StreamMessage msg2 = (StreamMessage) consumer.receive();
 
-        byte b1 = msg2.readByte();
+        msg2.readByte();
         try
         {
-            byte b2 = msg2.readByte();
+            msg2.readByte();
         }
         catch (Exception e)
         {
diff --git a/java/client/src/test/java/org/apache/qpid/test/unit/topic/TopicSessionTest.java b/java/client/src/test/java/org/apache/qpid/test/unit/topic/TopicSessionTest.java
index 14ceaa75f1..794316d2f5 100644
--- a/java/client/src/test/java/org/apache/qpid/test/unit/topic/TopicSessionTest.java
+++ b/java/client/src/test/java/org/apache/qpid/test/unit/topic/TopicSessionTest.java
@@ -260,7 +260,7 @@ public class TopicSessionTest extends TestCase
         TopicSession session2 = conn.createTopicSession(false, Session.AUTO_ACKNOWLEDGE);
         try
         {
-            MessageConsumer consumer2 = session2.createConsumer(topic);
+            session2.createConsumer(topic);
             fail("Expected a JMSException when subscribing to a temporary topic created on adifferent session");
         }
         catch (JMSException je)
diff --git a/java/systests/src/test/java/org/apache/qpid/server/exchange/HeadersExchangeTest.java b/java/systests/src/test/java/org/apache/qpid/server/exchange/HeadersExchangeTest.java
index c220442a78..c01241d11d 100644
--- a/java/systests/src/test/java/org/apache/qpid/server/exchange/HeadersExchangeTest.java
+++ b/java/systests/src/test/java/org/apache/qpid/server/exchange/HeadersExchangeTest.java
@@ -43,8 +43,6 @@ public class HeadersExchangeTest extends AbstractHeadersExchangeTestBase
         TestQueue q6 = bindDefault("F0000=Aardvark", "F0001=Bear");
         TestQueue q7 = bindDefault("F0000", "F0001=Bear");
         TestQueue q8 = bindDefault("F0000=Aardvark", "F0001");
-        TestQueue q9 = bindDefault("F0000=Apple", "F0001=Banana");
-        TestQueue q10 = bindDefault("F0000=Apple", "F0001");
 
         routeAndTest(new Message("Message1", "F0000"), q1);
         routeAndTest(new Message("Message2", "F0000=Aardvark"), q1, q2);
@@ -74,7 +72,6 @@ public class HeadersExchangeTest extends AbstractHeadersExchangeTestBase
         TestQueue q2 = bindDefault("F0000=Aardvark", "F0001=Bear", "X-match=any");
         TestQueue q3 = bindDefault("F0000", "F0001=Bear", "X-match=any");
         TestQueue q4 = bindDefault("F0000=Aardvark", "F0001", "X-match=any");
-        TestQueue q5 = bindDefault("F0000=Apple", "F0001=Banana", "X-match=any");
         TestQueue q6 = bindDefault("F0000=Apple", "F0001", "X-match=any");
 
         routeAndTest(new Message("Message1", "F0000"), q1, q3);
@@ -87,16 +84,14 @@ public class HeadersExchangeTest extends AbstractHeadersExchangeTestBase
 
     public void testMandatory() throws AMQException
     {
-        TestQueue q1 = bindDefault("F0000");
+        bindDefault("F0000");
         Message m1 = new Message("Message1", "XXXXX");
         Message m2 = new Message("Message2", "F0000");
         BasicPublishBody pb1 = m1.getPublishBody();
         pb1.mandatory = true;
-        BasicPublishBody pb2 = m1.getPublishBody();
+        BasicPublishBody pb2 = m2.getPublishBody();
         pb2.mandatory = true;
         routeAndTest(m1,true);
-
-
     }
 
     public static junit.framework.Test suite()
diff --git a/java/systests/src/test/java/org/apache/qpid/server/exchange/ReturnUnroutableMandatoryMessageTest.java b/java/systests/src/test/java/org/apache/qpid/server/exchange/ReturnUnroutableMandatoryMessageTest.java
index 4dffe3e75f..ec6a82cc29 100644
--- a/java/systests/src/test/java/org/apache/qpid/server/exchange/ReturnUnroutableMandatoryMessageTest.java
+++ b/java/systests/src/test/java/org/apache/qpid/server/exchange/ReturnUnroutableMandatoryMessageTest.java
@@ -5,7 +5,6 @@ import org.apache.log4j.Logger;
 import org.apache.qpid.test.VMBrokerSetup;

 import org.apache.qpid.server.registry.ApplicationRegistry;

 import org.apache.qpid.server.util.TestApplicationRegistry;

-import org.apache.qpid.server.store.TestableMemoryMessageStore;

 import org.apache.qpid.client.*;

 import org.apache.qpid.url.AMQBindingURL;

 import org.apache.qpid.url.BindingURL;

@@ -57,16 +56,12 @@ public class ReturnUnroutableMandatoryMessageTest extends TestCase implements Ex
         _bouncedMessageList.clear();

         Connection con = new AMQConnection("vm://:1", "guest", "guest", "consumer1", "/test");

 

-        TestableMemoryMessageStore store = (TestableMemoryMessageStore) ApplicationRegistry.getInstance().getMessageStore();

-

         AMQSession consumerSession = (AMQSession) con.createSession(false, Session.CLIENT_ACKNOWLEDGE);

 

-

         AMQHeadersExchange queue = new AMQHeadersExchange(new AMQBindingURL(ExchangeDefaults.HEADERS_EXCHANGE_CLASS+"://"+ExchangeDefaults.HEADERS_EXCHANGE_NAME+"/test/queue1?"+ BindingURL.OPTION_ROUTING_KEY+"='F0000=1'"));

         FieldTable ft = new PropertyFieldTable();

         ft.setString("F1000","1");

         MessageConsumer consumer = consumerSession.createConsumer(queue, AMQSession.DEFAULT_PREFETCH_LOW_MARK, AMQSession.DEFAULT_PREFETCH_HIGH_MARK, false, false, (String)null, ft);

-

         

         //force synch to ensure the consumer has resulted in a bound queue

         ((AMQSession) consumerSession).declareExchangeSynch(ExchangeDefaults.HEADERS_EXCHANGE_NAME, ExchangeDefaults.HEADERS_EXCHANGE_CLASS);