summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Gemmell <robbie@apache.org>2011-04-04 14:35:59 +0000
committerRobert Gemmell <robbie@apache.org>2011-04-04 14:35:59 +0000
commita9bec14623229056fc983934da71d046cabfc1ec (patch)
tree162ece390d45dee82a8ec5265708a1bd91e5ac1a
parent10e79a7841a1a7cd07f3c8abfed3702f1d1904d4 (diff)
downloadqpid-python-a9bec14623229056fc983934da71d046cabfc1ec.tar.gz
QPID-3183: some minor improvements to the recently seperated QueueRunner class, based on review feedback from Keith Wall for QPID-3167
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1088639 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java13
1 files changed, 9 insertions, 4 deletions
diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java
index 44b7c95535..7e1d57e205 100644
--- a/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java
+++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/QueueRunner.java
@@ -27,13 +27,18 @@ import org.apache.qpid.server.logging.actors.CurrentActor;
import org.apache.qpid.server.queue.QueueRunner;
import org.apache.qpid.server.queue.SimpleAMQQueue;
-
+/**
+ * QueueRunners are Runnables used to process a queue when requiring
+ * asynchronous message delivery to subscriptions, which is necessary
+ * when straight-through delivery of a message to a subscription isn't
+ * possible during the enqueue operation.
+ */
public class QueueRunner implements ReadWriteRunnable
{
private static final Logger _logger = Logger.getLogger(QueueRunner.class);
- private String _name;
- private SimpleAMQQueue _queue;
+ private final String _name;
+ private final SimpleAMQQueue _queue;
public QueueRunner(SimpleAMQQueue queue, long count)
{
@@ -53,7 +58,7 @@ public class QueueRunner implements ReadWriteRunnable
}
catch (AMQException e)
{
- _logger.error(e);
+ _logger.error("Exception during asynchronous delivery by " + _name, e);
}
finally
{