QPID-3820: Sporadic failures from ProducerFlowControlTest

The tests rely on a sync() to make sure the Broker has received the sent messages and has had a chance to invoke flow-control. However,
a defect in tests testClientLogMessages and testSendTimeout meant that an inactive session was actually being sync'd, rather than
the one used to produce the messages.  This will probably explain the sporadic failure.

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1241866 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 2 insertions, 2 deletions

diff --git a/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java b/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java
index d744b13935..ad8c856a74 100644
--- a/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java
+++ b/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java
@@ -178,7 +178,7 @@ public class ProducerFlowControlTest extends AbstractTestLogging
         producer = session.createProducer(queue);
 
         // try to send 5 messages (should block after 4)
-        MessageSender sender = sendMessagesAsync(producer, producerSession, 5, 50L);
+        MessageSender sender = sendMessagesAsync(producer, session, 5, 50L);
 
         List<String> results = waitAndFindMatches("Message send delayed by", TIMEOUT);
         assertTrue("No delay messages logged by client",results.size()!=0);
@@ -280,7 +280,7 @@ public class ProducerFlowControlTest extends AbstractTestLogging
         producer = session.createProducer(queue);
 
         // try to send 5 messages (should block after 4)
-        MessageSender sender = sendMessagesAsync(producer, producerSession, 5, 100L);
+        MessageSender sender = sendMessagesAsync(producer, session, 5, 100L);
 
         Exception e = sender.awaitSenderException(10000);