Ignore QPID_ env variables that don't correspond to known options.

git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/branches/M2@558099 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 12 insertions, 12 deletions

diff --git a/cpp/lib/common/CommonOptions.cpp b/cpp/lib/common/CommonOptions.cpp
index ebb3543105..2b6657b4e0 100644
--- a/cpp/lib/common/CommonOptions.cpp
+++ b/cpp/lib/common/CommonOptions.cpp
@@ -26,20 +26,20 @@ namespace qpid {
 
 namespace program_options {
 
-char env2optchar(char env) {
-    return (env=='_') ? '-' : tolower(env);
-}
-    
-const std::string envPrefix("QPID_");
-
-std::string env2option(const std::string& env) {
-    if (env.find(envPrefix) ==0) {
-        std::string opt = env.substr(envPrefix.size());
-        std::transform(opt.begin(), opt.end(), opt.begin(), env2optchar);
-        return opt;
+static const std::string prefix("QPID_");
+
+static char env2optchar(char env) { return (env=='_') ? '-' : tolower(env); }
+
+std::string EnvMapper::operator()(const std::string& env) {
+    if (env.substr(0, prefix.size()) == prefix) {
+        std::string opt = env.substr(prefix.size());
+        transform(opt.begin(), opt.end(), opt.begin(), env2optchar);
+        // Ignore env vars that don't match to known options.
+        if (opts.find_nothrow(opt, false))
+            return opt;
     }
     return std::string();
-} 
+}
 
 } // namespace program_options