diff options
| author | Andrew Stitcher <astitcher@apache.org> | 2009-09-22 15:59:53 +0000 |
|---|---|---|
| committer | Andrew Stitcher <astitcher@apache.org> | 2009-09-22 15:59:53 +0000 |
| commit | 3d3fb015b49b088a6e1f641437cd6b7acb0ed6ec (patch) | |
| tree | 92337ec015253d12f5ad045922592d791ae3f1a3 /cpp/src/qpid/sys/AsynchIOHandler.cpp | |
| parent | 4551735283dd89c17529782305679a9ac744d31f (diff) | |
| download | qpid-python-3d3fb015b49b088a6e1f641437cd6b7acb0ed6ec.tar.gz | |
Make the AsynchIO API more consistent
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@817711 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'cpp/src/qpid/sys/AsynchIOHandler.cpp')
| -rw-r--r-- | cpp/src/qpid/sys/AsynchIOHandler.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/cpp/src/qpid/sys/AsynchIOHandler.cpp b/cpp/src/qpid/sys/AsynchIOHandler.cpp index 46d8f3b4f1..ae41eacfc3 100644 --- a/cpp/src/qpid/sys/AsynchIOHandler.cpp +++ b/cpp/src/qpid/sys/AsynchIOHandler.cpp @@ -103,13 +103,11 @@ void AsynchIOHandler::giveReadCredit(int32_t credit) { aio->startReading(); } -bool AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) { +void AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) { if (readError) { - return false; + return; } - bool ret = true; - // Check here for read credit if (readCredit.get() != InfiniteCredit) { // TODO In theory should be able to use an atomic operation before taking the lock @@ -119,7 +117,6 @@ bool AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) { assert(readCredit.get() >= 0); if (readCredit.get() == 0) { aio->stopReading(); - ret = false; } } } @@ -166,7 +163,6 @@ bool AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) { // Give whole buffer back to aio subsystem aio->queueReadBuffer(buff); } - return ret; } void AsynchIOHandler::eof(AsynchIO&) { |