Fixed locking (lock was not being released for invocation on callback due to being locked twice but unlocked only once)

git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@594812 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 12 insertions, 3 deletions

diff --git a/cpp/src/qpid/sys/Serializer.cpp b/cpp/src/qpid/sys/Serializer.cpp
index f02e51ddb4..a82982a0c8 100644
--- a/cpp/src/qpid/sys/Serializer.cpp
+++ b/cpp/src/qpid/sys/Serializer.cpp
@@ -51,11 +51,20 @@ void SerializerBase::notifyWorker() {
         lock.notify();
 }
 
-void SerializerBase::run() {
+bool SerializerBase::running() {
+    Mutex::ScopedLock l(lock);
+    return state != SHUTDOWN;
+}
+
+void SerializerBase::wait() {
     Mutex::ScopedLock l(lock);
-    while (state != SHUTDOWN) {
+    lock.wait();
+}
+
+void SerializerBase::run() {
+    while (running()) {
         dispatch();
-        lock.wait();
+        wait();
     }
 }