Ignore exceptions from detach() in ~SessionImpl.

Otherwise clients can crash in terminate() if there is an error,
e.g. a TransportFailure.


git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@829912 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 5 insertions, 3 deletions

diff --git a/cpp/src/qpid/client/SessionImpl.cpp b/cpp/src/qpid/client/SessionImpl.cpp
index d443a1170b..b3181bdb3c 100644
--- a/cpp/src/qpid/client/SessionImpl.cpp
+++ b/cpp/src/qpid/client/SessionImpl.cpp
@@ -76,9 +76,11 @@ SessionImpl::~SessionImpl() {
         Lock l(state);
         if (state != DETACHED && state != DETACHING) {
             QPID_LOG(warning, "Session was not closed cleanly: " << id);
-            // Inform broker but don't wait for detached as that deadlocks.
-            // The detached will be ignored as the channel will be invalid.
-            if (autoDetach) detach();
+            try {
+                // Inform broker but don't wait for detached as that deadlocks.
+                // The detached will be ignored as the channel will be invalid.
+                if (autoDetach) detach();
+            } catch (...) {}    // ignore errors.
             setState(DETACHED);
             handleClosed();
             state.waitWaiters();