diff options
| author | Alan Conway <aconway@apache.org> | 2007-01-15 13:58:07 +0000 |
|---|---|---|
| committer | Alan Conway <aconway@apache.org> | 2007-01-15 13:58:07 +0000 |
| commit | 722425e4d5db1e01f2d4ff2e46d03e1187da8407 (patch) | |
| tree | 4b3ddc5b3ee880d2656f4ae986d0f573ba6b804e /cpp/tests/AccumulatedAckTest.cpp | |
| parent | fe6d706ad7085de5dd0526ec0c1d7983ed61aaf3 (diff) | |
| download | qpid-python-722425e4d5db1e01f2d4ff2e46d03e1187da8407.tar.gz | |
2006-12-08 Jim Meyering <meyering@redhat.com>
Ensure that AccumulatedAck.range is not used uninitialized.
* lib/broker/AccumulatedAck.h (AccumulatedAck): Make this a class,
rather than a struct.
(AccumulatedAck::AccumulatedAck): Add a constructor to require
initialization of the "range" member.
* lib/broker/BrokerChannel.cpp (Channel) [accumulatedAck]: Initialize.
* tests/TxAckTest.cpp (TxAckTest) [acked]: Likewise.
* tests/AccumulatedAckTest.cpp (testCovers): Initialize local.
(testUpdateAndConsolidate): Likewise.
git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@496317 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'cpp/tests/AccumulatedAckTest.cpp')
| -rw-r--r-- | cpp/tests/AccumulatedAckTest.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/cpp/tests/AccumulatedAckTest.cpp b/cpp/tests/AccumulatedAckTest.cpp index bfd9358422..a2ee3df752 100644 --- a/cpp/tests/AccumulatedAckTest.cpp +++ b/cpp/tests/AccumulatedAckTest.cpp @@ -36,8 +36,7 @@ class AccumulatedAckTest : public CppUnit::TestCase public: void testCovers() { - AccumulatedAck ack; - ack.range = 5; + AccumulatedAck ack(5); ack.individual.push_back(7); ack.individual.push_back(9); @@ -56,8 +55,7 @@ class AccumulatedAckTest : public CppUnit::TestCase void testUpdateAndConsolidate() { - AccumulatedAck ack; - ack.clear(); + AccumulatedAck ack(0); ack.update(1, false); ack.update(3, false); ack.update(10, false); |