diff options
author | Alan Conway <aconway@apache.org> | 2008-10-25 01:55:06 +0000 |
---|---|---|
committer | Alan Conway <aconway@apache.org> | 2008-10-25 01:55:06 +0000 |
commit | 10d07002af4b211dfbbc3341a4edb6ec4c2e5cb5 (patch) | |
tree | 18573267ea026fd920684ad77dc139638334fc6d /qpid/cpp/src/qpid/client/FlowControl.h | |
parent | 10beffb0c6d4233422f668d9d346770ad2f50295 (diff) | |
download | qpid-python-10d07002af4b211dfbbc3341a4edb6ec4c2e5cb5.tar.gz |
Client API change: Centralize access to subscription status, better control of acquire/accept.
client/AckPolicy: removed, functionality moved to Subscription and SubscriptionSettings
client/SubscriptionSettings: struct aggregates flow control & accept-acquire parameters for subscribe.
client/Subscription: represents active subscription. Query settings, unacked messages, manual accept/acquire
client/SubscriptionManager: use AcceptMode, AcquireMode enums rather than confusing bools.
Issues addressed by the change:
- old use of bool for acceptMode was inverted wrt AMQP enum values, bools are confusing.
- old AckPolicy was broken - not possible to access the instance associated with an active subscription
- old AckPolicy did not provide a way to do manual acquire, only accept.
- setting values on SubscriptionManager to apply to subsequent subscriptions is awkward & error-prone, now can use SubscriptionSettings to control on each subscribe individually.
- a subscription is a central concept in AMQP, it deserves to be a class. Subscription and SubscriptionSettings provides a single point for future expansion of interactions with a a Subscription.
git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk@707808 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/cpp/src/qpid/client/FlowControl.h')
-rw-r--r-- | qpid/cpp/src/qpid/client/FlowControl.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/qpid/cpp/src/qpid/client/FlowControl.h b/qpid/cpp/src/qpid/client/FlowControl.h index 081061ac02..0f5f8596ec 100644 --- a/qpid/cpp/src/qpid/client/FlowControl.h +++ b/qpid/cpp/src/qpid/client/FlowControl.h @@ -22,6 +22,8 @@ * */ +#include <qpid/sys/IntegerTypes.h> + namespace qpid { namespace client { @@ -40,9 +42,8 @@ namespace client { * is renewed. * * In "window mode" credit is automatically renewed when a message is - * acknowledged (@see AckPolicy) In non-window mode credit is not - * automatically renewed, it must be explicitly re-set (@see - * SubscriptionManager) + * accepted. In non-window mode credit is not automatically renewed, + * it must be explicitly re-set (@see Subscription) */ struct FlowControl { static const uint32_t UNLIMITED=0xFFFFFFFF; |