diff options
author | Ted Ross <tross@apache.org> | 2008-09-15 15:37:59 +0000 |
---|---|---|
committer | Ted Ross <tross@apache.org> | 2008-09-15 15:37:59 +0000 |
commit | 9659efe01f8d8cb2b4b3e1a27d16de35bd8d7db7 (patch) | |
tree | 116d3bc5acdaabfaa3147d58df7e01d16e94c2d8 /qpid/cpp/src | |
parent | 3db85445da9067144012c8ef37366cc82c87e9c1 (diff) | |
download | qpid-python-9659efe01f8d8cb2b4b3e1a27d16de35bd8d7db7.tar.gz |
QPID-1274 - Changed C++ namespace for generated management code. Improved efficiency of generated functions to use const references for non-simple types.
git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk@695511 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/cpp/src')
31 files changed, 139 insertions, 123 deletions
diff --git a/qpid/cpp/src/Makefile.am b/qpid/cpp/src/Makefile.am index 9b391a907f..9bef06e7bb 100644 --- a/qpid/cpp/src/Makefile.am +++ b/qpid/cpp/src/Makefile.am @@ -28,7 +28,7 @@ $(rgen_generator): # Management generator. mgen_dir=$(top_srcdir)/managementgen -mgen_cmd=$(mgen_dir)/qmf-gen -m $(srcdir)/managementgen.mk -o gen/qpid/management \ +mgen_cmd=$(mgen_dir)/qmf-gen -m $(srcdir)/managementgen.mk -o gen/qmf \ $(top_srcdir)/../specs/management-schema.xml \ $(srcdir)/qpid/acl/management-schema.xml diff --git a/qpid/cpp/src/qpid/DataDir.h b/qpid/cpp/src/qpid/DataDir.h index 7de5ebf62d..6b45d8747b 100644 --- a/qpid/cpp/src/qpid/DataDir.h +++ b/qpid/cpp/src/qpid/DataDir.h @@ -41,8 +41,8 @@ class DataDir DataDir (std::string path); ~DataDir (); - bool isEnabled () { return enabled; } - std::string getPath () { return dirPath; } + bool isEnabled() { return enabled; } + const std::string& getPath() { return dirPath; } }; } // namespace qpid diff --git a/qpid/cpp/src/qpid/acl/Acl.cpp b/qpid/cpp/src/qpid/acl/Acl.cpp index f9c307c7d3..0a793c88e0 100644 --- a/qpid/cpp/src/qpid/acl/Acl.cpp +++ b/qpid/cpp/src/qpid/acl/Acl.cpp @@ -24,39 +24,38 @@ #include "qpid/Options.h" #include "qpid/shared_ptr.h" #include "qpid/log/Logger.h" -#include "qpid/management/PackageACL.h" +#include "qmf/org/apache/qpid/acl/Package.h" #include <map> #include <boost/utility/in_place_factory.hpp> -namespace qpid { -namespace acl { - using namespace std; +using namespace qpid::acl; using qpid::management::ManagementAgent; using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; +namespace _qmf = qmf::org::apache::qpid::acl; - Acl::Acl (AclValues& av, broker::Broker& b): aclValues(av), broker(&b), transferAcl(false) - { +Acl::Acl (AclValues& av, broker::Broker& b): aclValues(av), broker(&b), transferAcl(false) +{ - ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); - - if (agent != 0){ - management::PackageACL packageInit(agent); - mgmtObject = new management::Acl (agent, this, broker); - agent->addObject (mgmtObject); - } - - if (!readAclFile()){ - throw Exception("Could not read ACL file"); - if (mgmtObject!=0) mgmtObject->set_enforcingAcl(0); - } - QPID_LOG(info, "ACL Plugin loaded"); + ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); + + if (agent != 0){ + _qmf::Package packageInit(agent); + mgmtObject = new _qmf::Acl (agent, this, broker); + agent->addObject (mgmtObject); + } + + if (!readAclFile()){ + throw Exception("Could not read ACL file"); + if (mgmtObject!=0) mgmtObject->set_enforcingAcl(0); + } + QPID_LOG(info, "ACL Plugin loaded"); if (mgmtObject!=0) mgmtObject->set_enforcingAcl(1); - } +} bool Acl::authorise(const std::string& id, const Action& action, const ObjectType& objType, const std::string& name, std::map<Property, std::string>* params) { @@ -147,7 +146,7 @@ using qpid::management::Args; switch (methodId) { - case management::Acl::METHOD_RELOADACLFILE : + case _qmf::Acl::METHOD_RELOADACLFILE : readAclFile(); status = Manageable::STATUS_OK; break; @@ -155,4 +154,3 @@ using qpid::management::Args; return status; } -}} // namespace qpid::acl diff --git a/qpid/cpp/src/qpid/acl/Acl.h b/qpid/cpp/src/qpid/acl/Acl.h index 22450709d9..b072d24cc0 100644 --- a/qpid/cpp/src/qpid/acl/Acl.h +++ b/qpid/cpp/src/qpid/acl/Acl.h @@ -27,7 +27,7 @@ #include "qpid/RefCounted.h" #include "qpid/broker/AclModule.h" #include "qpid/management/Manageable.h" -#include "qpid/management/Acl.h" +#include "qmf/org/apache/qpid/acl/Acl.h" #include <map> #include <string> @@ -56,7 +56,7 @@ private: broker::Broker* broker; bool transferAcl; boost::shared_ptr<AclData> data; - management::Acl* mgmtObject; // mgnt owns lifecycle + qmf::org::apache::qpid::acl::Acl* mgmtObject; // mgnt owns lifecycle public: diff --git a/qpid/cpp/src/qpid/acl/management-schema.xml b/qpid/cpp/src/qpid/acl/management-schema.xml index ebd1eb2a53..7d20353755 100644 --- a/qpid/cpp/src/qpid/acl/management-schema.xml +++ b/qpid/cpp/src/qpid/acl/management-schema.xml @@ -1,4 +1,4 @@ -<schema package="ACL"> +<schema package="org.apache.qpid.acl"> <!-- * Copyright (c) 2008 The Apache Software Foundation diff --git a/qpid/cpp/src/qpid/broker/Bridge.cpp b/qpid/cpp/src/qpid/broker/Bridge.cpp index 6e8dd818e5..93333f1410 100644 --- a/qpid/cpp/src/qpid/broker/Bridge.cpp +++ b/qpid/cpp/src/qpid/broker/Bridge.cpp @@ -31,20 +31,22 @@ using qpid::framing::FieldTable; using qpid::framing::Uuid; using qpid::framing::Buffer; using qpid::management::ManagementAgent; +namespace _qmf = qmf::org::apache::qpid::broker; namespace qpid { namespace broker { Bridge::Bridge(Link* _link, framing::ChannelId _id, CancellationListener l, - const management::ArgsLinkBridge& _args) : + const _qmf::ArgsLinkBridge& _args) : link(_link), id(_id), args(_args), mgmtObject(0), listener(l), name(Uuid(true).str()), persistenceId(0) { ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); if (agent != 0) { - mgmtObject = new management::Bridge(agent, this, link, id, args.i_durable, args.i_src, args.i_dest, - args.i_key, args.i_srcIsQueue, args.i_srcIsLocal, - args.i_tag, args.i_excludes); + mgmtObject = new _qmf::Bridge + (agent, this, link, id, args.i_durable, args.i_src, args.i_dest, + args.i_key, args.i_srcIsQueue, args.i_srcIsLocal, + args.i_tag, args.i_excludes); if (!args.i_durable) agent->addObject(mgmtObject); } @@ -182,7 +184,7 @@ management::Manageable::status_t Bridge::ManagementMethod(uint32_t methodId, management::Args& /*args*/, string&) { - if (methodId == management::Bridge::METHOD_CLOSE) { + if (methodId == _qmf::Bridge::METHOD_CLOSE) { //notify that we are closed destroy(); return management::Manageable::STATUS_OK; diff --git a/qpid/cpp/src/qpid/broker/Bridge.h b/qpid/cpp/src/qpid/broker/Bridge.h index 8286f080d5..5ca73e4004 100644 --- a/qpid/cpp/src/qpid/broker/Bridge.h +++ b/qpid/cpp/src/qpid/broker/Bridge.h @@ -26,8 +26,8 @@ #include "qpid/framing/ChannelHandler.h" #include "qpid/framing/Buffer.h" #include "qpid/management/Manageable.h" -#include "qpid/management/ArgsLinkBridge.h" -#include "qpid/management/Bridge.h" +#include "qmf/org/apache/qpid/broker/ArgsLinkBridge.h" +#include "qmf/org/apache/qpid/broker/Bridge.h" #include <boost/function.hpp> #include <memory> @@ -45,7 +45,8 @@ public: typedef boost::shared_ptr<Bridge> shared_ptr; typedef boost::function<void(Bridge*)> CancellationListener; - Bridge(Link* link, framing::ChannelId id, CancellationListener l, const management::ArgsLinkBridge& args); + Bridge(Link* link, framing::ChannelId id, CancellationListener l, + const qmf::org::apache::qpid::broker::ArgsLinkBridge& args); ~Bridge(); void create(ConnectionState& c); @@ -73,8 +74,8 @@ private: Link* link; framing::ChannelId id; - management::ArgsLinkBridge args; - management::Bridge* mgmtObject; + qmf::org::apache::qpid::broker::ArgsLinkBridge args; + qmf::org::apache::qpid::broker::Bridge* mgmtObject; CancellationListener listener; std::string name; mutable uint64_t persistenceId; diff --git a/qpid/cpp/src/qpid/broker/Broker.cpp b/qpid/cpp/src/qpid/broker/Broker.cpp index a56b2bd392..8b3be54d15 100644 --- a/qpid/cpp/src/qpid/broker/Broker.cpp +++ b/qpid/cpp/src/qpid/broker/Broker.cpp @@ -30,9 +30,9 @@ #include "TopicExchange.h" #include "Link.h" -#include "qpid/management/PackageQpid.h" +#include "qmf/org/apache/qpid/broker/Package.h" +#include "qmf/org/apache/qpid/broker/ArgsBrokerEcho.h" #include "qpid/management/ManagementExchange.h" -#include "qpid/management/ArgsBrokerEcho.h" #include "qpid/log/Statement.h" #include "qpid/framing/AMQFrame.h" #include "qpid/framing/ProtocolInitiation.h" @@ -70,7 +70,7 @@ using qpid::management::ManagementBroker; using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; -using qpid::management::ArgsBrokerEcho; +namespace _qmf = qmf::org::apache::qpid::broker; namespace qpid { namespace broker { @@ -146,12 +146,12 @@ Broker::Broker(const Broker::Options& conf) : ((ManagementBroker*) managementAgent)->configure (dataDir.isEnabled () ? dataDir.getPath () : string (), conf.mgmtPubInterval, this, conf.workerThreads + 3); - qpid::management::PackageQpid packageInitializer (managementAgent); + _qmf::Package packageInitializer (managementAgent); System* system = new System (dataDir.isEnabled () ? dataDir.getPath () : string ()); systemObject = System::shared_ptr (system); - mgmtObject = new management::Broker (managementAgent, this, system, conf.port); + mgmtObject = new _qmf::Broker (managementAgent, this, system, conf.port); mgmtObject->set_workerThreads (conf.workerThreads); mgmtObject->set_maxConns (conf.maxConnections); mgmtObject->set_connBacklog (conf.connectionBacklog); @@ -330,12 +330,12 @@ Manageable::status_t Broker::ManagementMethod (uint32_t methodId, switch (methodId) { - case management::Broker::METHOD_ECHO : + case _qmf::Broker::METHOD_ECHO : status = Manageable::STATUS_OK; break; - case management::Broker::METHOD_CONNECT : { - management::ArgsBrokerConnect& hp= - dynamic_cast<management::ArgsBrokerConnect&>(args); + case _qmf::Broker::METHOD_CONNECT : { + _qmf::ArgsBrokerConnect& hp= + dynamic_cast<_qmf::ArgsBrokerConnect&>(args); if (hp.i_useSsl) return Manageable::STATUS_FEATURE_NOT_IMPLEMENTED; diff --git a/qpid/cpp/src/qpid/broker/Broker.h b/qpid/cpp/src/qpid/broker/Broker.h index 5b701e8513..39b9c334eb 100644 --- a/qpid/cpp/src/qpid/broker/Broker.h +++ b/qpid/cpp/src/qpid/broker/Broker.h @@ -35,8 +35,8 @@ #include "System.h" #include "qpid/management/Manageable.h" #include "qpid/management/ManagementBroker.h" -#include "qpid/management/Broker.h" -#include "qpid/management/ArgsBrokerConnect.h" +#include "qmf/org/apache/qpid/broker/Broker.h" +#include "qmf/org/apache/qpid/broker/ArgsBrokerConnect.h" #include "qpid/Options.h" #include "qpid/Plugin.h" #include "qpid/DataDir.h" @@ -107,7 +107,7 @@ class Broker : public sys::Runnable, public Plugin::Target, DtxManager dtxManager; SessionManager sessionManager; management::ManagementAgent* managementAgent; - management::Broker* mgmtObject; + qmf::org::apache::qpid::broker::Broker* mgmtObject; Vhost::shared_ptr vhostObject; System::shared_ptr systemObject; diff --git a/qpid/cpp/src/qpid/broker/Connection.cpp b/qpid/cpp/src/qpid/broker/Connection.cpp index 5bc3c175b3..dd62c8e6e8 100644 --- a/qpid/cpp/src/qpid/broker/Connection.cpp +++ b/qpid/cpp/src/qpid/broker/Connection.cpp @@ -43,6 +43,7 @@ using qpid::management::ManagementAgent; using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; +namespace _qmf = qmf::org::apache::qpid::broker; namespace qpid { namespace broker { @@ -68,7 +69,7 @@ Connection::Connection(ConnectionOutputHandler* out_, Broker& broker_, const std // TODO set last bool true if system connection if (agent != 0) - mgmtObject = new management::Connection(agent, this, parent, mgmtId, !isLink,false); + mgmtObject = new _qmf::Connection(agent, this, parent, mgmtId, !isLink, false); agent->addObject(mgmtObject); } } @@ -232,7 +233,7 @@ Manageable::status_t Connection::ManagementMethod(uint32_t methodId, Args&, stri switch (methodId) { - case management::Connection::METHOD_CLOSE : + case _qmf::Connection::METHOD_CLOSE : mgmtClosing = true; if (mgmtObject != 0) mgmtObject->set_closing(1); out.activateOutput(); diff --git a/qpid/cpp/src/qpid/broker/Connection.h b/qpid/cpp/src/qpid/broker/Connection.h index 137a829f7f..b81f1eda21 100644 --- a/qpid/cpp/src/qpid/broker/Connection.h +++ b/qpid/cpp/src/qpid/broker/Connection.h @@ -43,7 +43,7 @@ #include "ConnectionState.h" #include "SessionHandler.h" #include "qpid/management/Manageable.h" -#include "qpid/management/Connection.h" +#include "qmf/org/apache/qpid/broker/Connection.h" #include "qpid/RefCounted.h" #include <boost/ptr_container/ptr_map.hpp> @@ -104,7 +104,7 @@ class Connection : public sys::ConnectionInputHandler, bool mgmtClosing; const std::string mgmtId; boost::function0<void> ioCallback; - management::Connection* mgmtObject; + qmf::org::apache::qpid::broker::Connection* mgmtObject; LinkRegistry& links; }; diff --git a/qpid/cpp/src/qpid/broker/DirectExchange.cpp b/qpid/cpp/src/qpid/broker/DirectExchange.cpp index bc6d7fe495..b4b892feeb 100644 --- a/qpid/cpp/src/qpid/broker/DirectExchange.cpp +++ b/qpid/cpp/src/qpid/broker/DirectExchange.cpp @@ -26,6 +26,7 @@ using namespace qpid::broker; using namespace qpid::framing; using namespace qpid::sys; using qpid::management::Manageable; +namespace _qmf = qmf::org::apache::qpid::broker; DirectExchange::DirectExchange(const string& _name, Manageable* _parent) : Exchange(_name, _parent) { @@ -47,7 +48,7 @@ bool DirectExchange::bind(Queue::shared_ptr queue, const string& routingKey, con if (bindings[routingKey].add_unless(b, MatchQueue(queue))) { if (mgmtExchange != 0) { mgmtExchange->inc_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->inc_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->inc_bindingCount(); } return true; } else { @@ -60,7 +61,7 @@ bool DirectExchange::unbind(Queue::shared_ptr queue, const string& routingKey, c if (bindings[routingKey].remove_if(MatchQueue(queue))) { if (mgmtExchange != 0) { mgmtExchange->dec_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->dec_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->dec_bindingCount(); } return true; } else { diff --git a/qpid/cpp/src/qpid/broker/Exchange.cpp b/qpid/cpp/src/qpid/broker/Exchange.cpp index 3c0f3b14e9..553fb8f374 100644 --- a/qpid/cpp/src/qpid/broker/Exchange.cpp +++ b/qpid/cpp/src/qpid/broker/Exchange.cpp @@ -30,6 +30,7 @@ using qpid::management::ManagementAgent; using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; +namespace _qmf = qmf::org::apache::qpid::broker; Exchange::Exchange (const string& _name, Manageable* parent) : name(_name), durable(false), persistenceId(0), mgmtExchange(0) @@ -39,7 +40,7 @@ Exchange::Exchange (const string& _name, Manageable* parent) : ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); if (agent != 0) { - mgmtExchange = new management::Exchange (agent, this, parent, _name, durable); + mgmtExchange = new _qmf::Exchange (agent, this, parent, _name, durable); agent->addObject (mgmtExchange); } } @@ -54,7 +55,7 @@ Exchange::Exchange(const string& _name, bool _durable, const qpid::framing::Fiel ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); if (agent != 0) { - mgmtExchange = new management::Exchange (agent, this, parent, _name, durable); + mgmtExchange = new _qmf::Exchange (agent, this, parent, _name, durable); if (!durable) { if (name == "") agent->addObject (mgmtExchange, 0x1000000000000004LL); // Special default exchange ID @@ -131,7 +132,8 @@ Exchange::Binding::Binding(const string& _key, Queue::shared_ptr _queue, Exchang if (mo != 0) { management::ObjectId queueId = mo->getObjectId(); - mgmtBinding = new management::Binding (agent, this, (Manageable*) parent, queueId, key, args); + mgmtBinding = new _qmf::Binding + (agent, this, (Manageable*) parent, queueId, key, args); agent->addObject (mgmtBinding); } } diff --git a/qpid/cpp/src/qpid/broker/Exchange.h b/qpid/cpp/src/qpid/broker/Exchange.h index 4f46741bfe..9901fbb18b 100644 --- a/qpid/cpp/src/qpid/broker/Exchange.h +++ b/qpid/cpp/src/qpid/broker/Exchange.h @@ -29,8 +29,8 @@ #include "PersistableExchange.h" #include "qpid/framing/FieldTable.h" #include "qpid/management/Manageable.h" -#include "qpid/management/Exchange.h" -#include "qpid/management/Binding.h" +#include "qmf/org/apache/qpid/broker/Exchange.h" +#include "qmf/org/apache/qpid/broker/Binding.h" namespace qpid { namespace broker { @@ -54,7 +54,7 @@ namespace qpid { Queue::shared_ptr queue; const std::string key; const framing::FieldTable args; - management::Binding* mgmtBinding; + qmf::org::apache::qpid::broker::Binding* mgmtBinding; Binding(const std::string& key, Queue::shared_ptr queue, Exchange* parent = 0, framing::FieldTable args = framing::FieldTable ()); @@ -68,7 +68,7 @@ namespace qpid { bool operator()(Exchange::Binding::shared_ptr b); }; - management::Exchange* mgmtExchange; + qmf::org::apache::qpid::broker::Exchange* mgmtExchange; public: typedef boost::shared_ptr<Exchange> shared_ptr; diff --git a/qpid/cpp/src/qpid/broker/FanOutExchange.cpp b/qpid/cpp/src/qpid/broker/FanOutExchange.cpp index 019c943ca1..1e03d34b25 100644 --- a/qpid/cpp/src/qpid/broker/FanOutExchange.cpp +++ b/qpid/cpp/src/qpid/broker/FanOutExchange.cpp @@ -24,6 +24,7 @@ using namespace qpid::broker; using namespace qpid::framing; using namespace qpid::sys; +namespace _qmf = qmf::org::apache::qpid::broker; FanOutExchange::FanOutExchange(const std::string& _name, Manageable* _parent) : Exchange(_name, _parent) @@ -46,7 +47,7 @@ bool FanOutExchange::bind(Queue::shared_ptr queue, const string& /*key*/, const if (bindings.add_unless(binding, MatchQueue(queue))) { if (mgmtExchange != 0) { mgmtExchange->inc_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->inc_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->inc_bindingCount(); } return true; } else { @@ -59,7 +60,7 @@ bool FanOutExchange::unbind(Queue::shared_ptr queue, const string& /*key*/, cons if (bindings.remove_if(MatchQueue(queue))) { if (mgmtExchange != 0) { mgmtExchange->dec_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->dec_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->dec_bindingCount(); } return true; } else { diff --git a/qpid/cpp/src/qpid/broker/HeadersExchange.cpp b/qpid/cpp/src/qpid/broker/HeadersExchange.cpp index f7842239da..5f89202c75 100644 --- a/qpid/cpp/src/qpid/broker/HeadersExchange.cpp +++ b/qpid/cpp/src/qpid/broker/HeadersExchange.cpp @@ -28,6 +28,7 @@ using namespace qpid::broker; using namespace qpid::framing; using namespace qpid::sys; +namespace _qmf = qmf::org::apache::qpid::broker; // TODO aconway 2006-09-20: More efficient matching algorithm. // The current search algorithm really sucks. @@ -81,7 +82,7 @@ bool HeadersExchange::bind(Queue::shared_ptr queue, const string& bindingKey, co if (bindings.add_unless(binding, MatchArgs(queue, args))) { if (mgmtExchange != 0) { mgmtExchange->inc_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->inc_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->inc_bindingCount(); } return true; } else { @@ -93,7 +94,7 @@ bool HeadersExchange::unbind(Queue::shared_ptr queue, const string& bindingKey, if (bindings.remove_if(MatchKey(queue, bindingKey))) { if (mgmtExchange != 0) { mgmtExchange->dec_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->dec_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->dec_bindingCount(); } return true; } else { diff --git a/qpid/cpp/src/qpid/broker/Link.cpp b/qpid/cpp/src/qpid/broker/Link.cpp index a53bf9e983..f5a7f3a4c3 100644 --- a/qpid/cpp/src/qpid/broker/Link.cpp +++ b/qpid/cpp/src/qpid/broker/Link.cpp @@ -24,7 +24,6 @@ #include "Broker.h" #include "Connection.h" #include "qpid/agent/ManagementAgent.h" -#include "qpid/management/Link.h" #include "boost/bind.hpp" #include "qpid/log/Statement.h" @@ -36,6 +35,7 @@ using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; using qpid::sys::Mutex; +namespace _qmf = qmf::org::apache::qpid::broker; Link::Link(LinkRegistry* _links, MessageStore* _store, @@ -62,7 +62,7 @@ Link::Link(LinkRegistry* _links, ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); if (agent != 0) { - mgmtObject = new management::Link(agent, this, parent, _host, _port, _useSsl, _durable); + mgmtObject = new _qmf::Link(agent, this, parent, _host, _port, _useSsl, _durable); if (!durable) agent->addObject(mgmtObject); } @@ -328,14 +328,14 @@ Manageable::status_t Link::ManagementMethod (uint32_t op, management::Args& args { switch (op) { - case management::Link::METHOD_CLOSE : + case _qmf::Link::METHOD_CLOSE : closing = true; if (state != STATE_CONNECTING) destroy(); return Manageable::STATUS_OK; - case management::Link::METHOD_BRIDGE : - management::ArgsLinkBridge& iargs = (management::ArgsLinkBridge&) args; + case _qmf::Link::METHOD_BRIDGE : + _qmf::ArgsLinkBridge& iargs = (_qmf::ArgsLinkBridge&) args; // Durable bridges are only valid on durable links if (iargs.i_durable && !durable) diff --git a/qpid/cpp/src/qpid/broker/Link.h b/qpid/cpp/src/qpid/broker/Link.h index 0422141ec7..dea28aad22 100644 --- a/qpid/cpp/src/qpid/broker/Link.h +++ b/qpid/cpp/src/qpid/broker/Link.h @@ -29,7 +29,7 @@ #include "qpid/sys/Mutex.h" #include "qpid/framing/FieldTable.h" #include "qpid/management/Manageable.h" -#include "qpid/management/Link.h" +#include "qmf/org/apache/qpid/broker/Link.h" #include <boost/ptr_container/ptr_vector.hpp> namespace qpid { @@ -53,7 +53,7 @@ namespace qpid { string username; string password; mutable uint64_t persistenceId; - management::Link* mgmtObject; + qmf::org::apache::qpid::broker::Link* mgmtObject; Broker* broker; int state; uint32_t visitCount; diff --git a/qpid/cpp/src/qpid/broker/LinkRegistry.cpp b/qpid/cpp/src/qpid/broker/LinkRegistry.cpp index 0703c276cf..31992d0af5 100644 --- a/qpid/cpp/src/qpid/broker/LinkRegistry.cpp +++ b/qpid/cpp/src/qpid/broker/LinkRegistry.cpp @@ -26,6 +26,7 @@ using namespace qpid::sys; using std::pair; using std::stringstream; using boost::intrusive_ptr; +namespace _qmf = qmf::org::apache::qpid::broker; #define LINK_MAINT_INTERVAL 2 @@ -107,7 +108,7 @@ pair<Bridge::shared_ptr, bool> LinkRegistry::declare(std::string& host, BridgeMap::iterator b = bridges.find(bridgeKey); if (b == bridges.end()) { - management::ArgsLinkBridge args; + _qmf::ArgsLinkBridge args; Bridge::shared_ptr bridge; args.i_durable = durable; diff --git a/qpid/cpp/src/qpid/broker/Queue.cpp b/qpid/cpp/src/qpid/broker/Queue.cpp index 2dbaef1b13..befc5c4eff 100644 --- a/qpid/cpp/src/qpid/broker/Queue.cpp +++ b/qpid/cpp/src/qpid/broker/Queue.cpp @@ -31,7 +31,7 @@ #include "qpid/framing/reply_exceptions.h" #include "qpid/sys/Monitor.h" #include "qpid/sys/Time.h" -#include "qpid/management/ArgsQueuePurge.h" +#include "qmf/org/apache/qpid/broker/ArgsQueuePurge.h" #include <iostream> #include <algorithm> @@ -49,6 +49,7 @@ using qpid::management::Manageable; using qpid::management::Args; using std::for_each; using std::mem_fun; +namespace _qmf = qmf::org::apache::qpid::broker; Queue::Queue(const string& _name, bool _autodelete, MessageStore* const _store, @@ -72,7 +73,7 @@ Queue::Queue(const string& _name, bool _autodelete, if (agent != 0) { - mgmtObject = new management::Queue (agent, this, parent, _name, _store != 0, _autodelete, _owner != 0); + mgmtObject = new _qmf::Queue(agent, this, parent, _name, _store != 0, _autodelete, _owner != 0); // Add the object to the management agent only if this queue is not durable. // If it's durable, we will add it later when the queue is assigned a persistenceId. @@ -732,8 +733,8 @@ Manageable::status_t Queue::ManagementMethod (uint32_t methodId, Args& args, str switch (methodId) { - case management::Queue::METHOD_PURGE : - management::ArgsQueuePurge iargs = dynamic_cast<const management::ArgsQueuePurge&>(args); + case _qmf::Queue::METHOD_PURGE : + _qmf::ArgsQueuePurge& iargs = (_qmf::ArgsQueuePurge&) args; purge (iargs.i_request); status = Manageable::STATUS_OK; break; diff --git a/qpid/cpp/src/qpid/broker/Queue.h b/qpid/cpp/src/qpid/broker/Queue.h index 1cf33b665f..f9f249cda8 100644 --- a/qpid/cpp/src/qpid/broker/Queue.h +++ b/qpid/cpp/src/qpid/broker/Queue.h @@ -31,7 +31,7 @@ #include "qpid/framing/FieldTable.h" #include "qpid/sys/Monitor.h" #include "qpid/management/Manageable.h" -#include "qpid/management/Queue.h" +#include "qmf/org/apache/qpid/broker/Queue.h" #include "qpid/framing/amqp_types.h" #include <boost/shared_ptr.hpp> @@ -87,7 +87,7 @@ namespace qpid { QueueBindings bindings; boost::shared_ptr<Exchange> alternateExchange; framing::SequenceNumber sequence; - management::Queue* mgmtObject; + qmf::org::apache::qpid::broker::Queue* mgmtObject; void push(boost::intrusive_ptr<Message>& msg); void setPolicy(std::auto_ptr<QueuePolicy> policy); diff --git a/qpid/cpp/src/qpid/broker/SessionState.cpp b/qpid/cpp/src/qpid/broker/SessionState.cpp index 027f8a212d..d0e75849d8 100644 --- a/qpid/cpp/src/qpid/broker/SessionState.cpp +++ b/qpid/cpp/src/qpid/broker/SessionState.cpp @@ -44,6 +44,7 @@ using qpid::management::ManagementAgent; using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; +namespace _qmf = qmf::org::apache::qpid::broker; SessionState::SessionState( Broker& b, SessionHandler& h, const SessionId& id, const SessionState::Configuration& config) @@ -60,7 +61,8 @@ SessionState::SessionState( if (parent != 0) { ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); if (agent != 0) { - mgmtObject = new management::Session (agent, this, parent, getId().getName()); + mgmtObject = new _qmf::Session + (agent, this, parent, getId().getName()); mgmtObject->set_attached (0); mgmtObject->set_detachedLifespan (0); agent->addObject (mgmtObject); @@ -127,15 +129,14 @@ Manageable::status_t SessionState::ManagementMethod (uint32_t methodId, switch (methodId) { - case management::Session::METHOD_DETACH : - if (handler != 0) - { + case _qmf::Session::METHOD_DETACH : + if (handler != 0) { handler->sendDetach(); } status = Manageable::STATUS_OK; break; - case management::Session::METHOD_CLOSE : + case _qmf::Session::METHOD_CLOSE : /* if (handler != 0) { @@ -145,8 +146,8 @@ Manageable::status_t SessionState::ManagementMethod (uint32_t methodId, break; */ - case management::Session::METHOD_SOLICITACK : - case management::Session::METHOD_RESETLIFESPAN : + case _qmf::Session::METHOD_SOLICITACK : + case _qmf::Session::METHOD_RESETLIFESPAN : status = Manageable::STATUS_NOT_IMPLEMENTED; break; } diff --git a/qpid/cpp/src/qpid/broker/SessionState.h b/qpid/cpp/src/qpid/broker/SessionState.h index 83d79a617d..e424559228 100644 --- a/qpid/cpp/src/qpid/broker/SessionState.h +++ b/qpid/cpp/src/qpid/broker/SessionState.h @@ -27,7 +27,7 @@ #include "qpid/framing/SequenceSet.h" #include "qpid/sys/Time.h" #include "qpid/management/Manageable.h" -#include "qpid/management/Session.h" +#include "qmf/org/apache/qpid/broker/Session.h" #include "SessionAdapter.h" #include "DeliveryAdapter.h" #include "IncompleteMessageList.h" @@ -122,7 +122,7 @@ class SessionState : public qpid::SessionState, MessageBuilder msgBuilder; IncompleteMessageList incomplete; IncompleteMessageList::CompletionListener enqueuedOp; - management::Session* mgmtObject; + qmf::org::apache::qpid::broker::Session* mgmtObject; friend class SessionManager; }; diff --git a/qpid/cpp/src/qpid/broker/System.cpp b/qpid/cpp/src/qpid/broker/System.cpp index d562c43069..7b5e843e90 100644 --- a/qpid/cpp/src/qpid/broker/System.cpp +++ b/qpid/cpp/src/qpid/broker/System.cpp @@ -27,6 +27,7 @@ using qpid::management::ManagementAgent; using namespace qpid::broker; using namespace std; +namespace _qmf = qmf::org::apache::qpid::broker; System::System (string _dataDir) : mgmtObject(0) { @@ -62,7 +63,7 @@ System::System (string _dataDir) : mgmtObject(0) } } - mgmtObject = new management::System (agent, this, systemId); + mgmtObject = new _qmf::System (agent, this, systemId); struct utsname _uname; if (uname (&_uname) == 0) { diff --git a/qpid/cpp/src/qpid/broker/System.h b/qpid/cpp/src/qpid/broker/System.h index ef7c6ba73b..42a816e095 100644 --- a/qpid/cpp/src/qpid/broker/System.h +++ b/qpid/cpp/src/qpid/broker/System.h @@ -21,7 +21,7 @@ // #include "qpid/management/Manageable.h" -#include "qpid/management/System.h" +#include "qmf/org/apache/qpid/broker/System.h" #include <boost/shared_ptr.hpp> #include <string> @@ -32,7 +32,7 @@ class System : public management::Manageable { private: - management::System* mgmtObject; + qmf::org::apache::qpid::broker::System* mgmtObject; public: diff --git a/qpid/cpp/src/qpid/broker/TopicExchange.cpp b/qpid/cpp/src/qpid/broker/TopicExchange.cpp index 48d6e88503..787cf9637c 100644 --- a/qpid/cpp/src/qpid/broker/TopicExchange.cpp +++ b/qpid/cpp/src/qpid/broker/TopicExchange.cpp @@ -24,6 +24,7 @@ using namespace qpid::broker; using namespace qpid::framing; using namespace qpid::sys; +namespace _qmf = qmf::org::apache::qpid::broker; // TODO aconway 2006-09-20: More efficient matching algorithm. // Areas for improvement: @@ -139,7 +140,7 @@ bool TopicExchange::bind(Queue::shared_ptr queue, const string& routingKey, cons bindings[routingPattern].push_back(binding); if (mgmtExchange != 0) { mgmtExchange->inc_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->inc_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->inc_bindingCount(); } return true; } @@ -160,7 +161,7 @@ bool TopicExchange::unbind(Queue::shared_ptr queue, const string& routingKey, co if(qv.empty()) bindings.erase(bi); if (mgmtExchange != 0) { mgmtExchange->dec_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->dec_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->dec_bindingCount(); } return true; } diff --git a/qpid/cpp/src/qpid/broker/Vhost.cpp b/qpid/cpp/src/qpid/broker/Vhost.cpp index c0eb6f03ed..4d9d3bb604 100644 --- a/qpid/cpp/src/qpid/broker/Vhost.cpp +++ b/qpid/cpp/src/qpid/broker/Vhost.cpp @@ -22,6 +22,7 @@ using namespace qpid::broker; using qpid::management::ManagementAgent; +namespace _qmf = qmf::org::apache::qpid::broker; Vhost::Vhost (management::Manageable* parentBroker) : mgmtObject(0) { @@ -31,7 +32,7 @@ Vhost::Vhost (management::Manageable* parentBroker) : mgmtObject(0) if (agent != 0) { - mgmtObject = new management::Vhost (agent, this, parentBroker, "/"); + mgmtObject = new _qmf::Vhost(agent, this, parentBroker, "/"); agent->addObject (mgmtObject, 0x1000000000000003LL); } } diff --git a/qpid/cpp/src/qpid/broker/Vhost.h b/qpid/cpp/src/qpid/broker/Vhost.h index bdc64e71be..59c0d4f959 100644 --- a/qpid/cpp/src/qpid/broker/Vhost.h +++ b/qpid/cpp/src/qpid/broker/Vhost.h @@ -21,7 +21,7 @@ // #include "qpid/management/Manageable.h" -#include "qpid/management/Vhost.h" +#include "qmf/org/apache/qpid/broker/Vhost.h" #include <boost/shared_ptr.hpp> namespace qpid { @@ -31,7 +31,7 @@ class Vhost : public management::Manageable { private: - management::Vhost* mgmtObject; + qmf::org::apache::qpid::broker::Vhost* mgmtObject; public: diff --git a/qpid/cpp/src/qpid/broker/XmlExchange.cpp b/qpid/cpp/src/qpid/broker/XmlExchange.cpp index b51791796d..5095e4a564 100644 --- a/qpid/cpp/src/qpid/broker/XmlExchange.cpp +++ b/qpid/cpp/src/qpid/broker/XmlExchange.cpp @@ -40,6 +40,7 @@ using namespace qpid::framing; using namespace qpid::sys; using qpid::management::Manageable; +namespace _qmf = qmf::org::apache::qpid::broker; namespace qpid { namespace broker { @@ -92,7 +93,7 @@ bool XmlExchange::bind(Queue::shared_ptr queue, const string& routingKey, const if (mgmtExchange != 0) { mgmtExchange->inc_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->inc_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->inc_bindingCount(); } return true; } else { @@ -113,7 +114,7 @@ bool XmlExchange::unbind(Queue::shared_ptr queue, const string& routingKey, cons if (bindingsMap[routingKey].remove_if(MatchQueue(queue))) { if (mgmtExchange != 0) { mgmtExchange->dec_bindingCount(); - ((management::Queue*) queue->GetManagementObject())->dec_bindingCount(); + ((_qmf::Queue*) queue->GetManagementObject())->dec_bindingCount(); } return true; } else { diff --git a/qpid/cpp/src/qpid/management/ManagementBroker.cpp b/qpid/cpp/src/qpid/management/ManagementBroker.cpp index bb36841965..3ae98e8264 100644 --- a/qpid/cpp/src/qpid/management/ManagementBroker.cpp +++ b/qpid/cpp/src/qpid/management/ManagementBroker.cpp @@ -39,6 +39,7 @@ using namespace qpid::management; using namespace qpid::broker; using namespace qpid::sys; using namespace std; +namespace _qmf = qmf::org::apache::qpid::broker; Mutex ManagementAgent::Singleton::lock; bool ManagementAgent::Singleton::disabled = false; @@ -113,7 +114,8 @@ ManagementBroker::~ManagementBroker () } } -void ManagementBroker::configure(string _dataDir, uint16_t _interval, broker::Broker* _broker, int _threads) +void ManagementBroker::configure(string _dataDir, uint16_t _interval, + qpid::broker::Broker* _broker, int _threads) { dataDir = _dataDir; interval = _interval; @@ -170,8 +172,8 @@ void ManagementBroker::writeData () } } -void ManagementBroker::setExchange (broker::Exchange::shared_ptr _mexchange, - broker::Exchange::shared_ptr _dexchange) +void ManagementBroker::setExchange (qpid::broker::Exchange::shared_ptr _mexchange, + qpid::broker::Exchange::shared_ptr _dexchange) { mExchange = _mexchange; dExchange = _dexchange; @@ -261,7 +263,7 @@ bool ManagementBroker::CheckHeader (Buffer& buf, uint8_t *opcode, uint32_t *seq) void ManagementBroker::SendBuffer (Buffer& buf, uint32_t length, - broker::Exchange::shared_ptr exchange, + qpid::broker::Exchange::shared_ptr exchange, string routingKey) { if (exchange.get() == 0) @@ -448,7 +450,7 @@ void ManagementBroker::handleMethodRequestLH (Buffer& inBuffer, string replyToKe EncodeHeader(outBuffer, 'm', sequence); if (acl != 0) { - string userId = ((const broker::ConnectionState*) connToken)->getUserId(); + string userId = ((const qpid::broker::ConnectionState*) connToken)->getUserId(); std::map<acl::Property, string> params; params[acl::SCHEMAPACKAGE] = packageName; params[acl::SCHEMACLASS] = className; @@ -748,7 +750,7 @@ void ManagementBroker::handleAttachRequestLH (Buffer& inBuffer, string replyToKe agent->objIdBank = assignedBank; agent->routingKey = replyToKey; agent->connectionRef = connectionRef; - agent->mgmtObject = new management::Agent (this, agent); + agent->mgmtObject = new _qmf::Agent (this, agent); agent->mgmtObject->set_connectionRef(agent->connectionRef); agent->mgmtObject->set_label (label); agent->mgmtObject->set_registeredTo (broker->GetManagementObject()->getObjectId()); @@ -831,7 +833,7 @@ bool ManagementBroker::authorizeAgentMessageLH(Message& msg) if (acl == 0) return true; - string userId = ((const broker::ConnectionState*) msg.getPublisher())->getUserId(); + string userId = ((const qpid::broker::ConnectionState*) msg.getPublisher())->getUserId(); string packageName; string className; uint8_t hash[16]; diff --git a/qpid/cpp/src/qpid/management/ManagementBroker.h b/qpid/cpp/src/qpid/management/ManagementBroker.h index e3b5504752..23fba74b83 100644 --- a/qpid/cpp/src/qpid/management/ManagementBroker.h +++ b/qpid/cpp/src/qpid/management/ManagementBroker.h @@ -30,7 +30,7 @@ #include "qpid/agent/ManagementAgent.h" #include "ManagementObject.h" #include "Manageable.h" -#include "qpid/management/Agent.h" +#include "qmf/org/apache/qpid/broker/Agent.h" #include <qpid/framing/AMQFrame.h> namespace qpid { @@ -47,10 +47,10 @@ class ManagementBroker : public ManagementAgent ManagementBroker (); virtual ~ManagementBroker (); - void configure (std::string dataDir, uint16_t interval, broker::Broker* broker, int threadPoolSize); + void configure (std::string dataDir, uint16_t interval, qpid::broker::Broker* broker, int threadPoolSize); void setInterval (uint16_t _interval) { interval = _interval; } - void setExchange (broker::Exchange::shared_ptr mgmtExchange, - broker::Exchange::shared_ptr directExchange); + void setExchange (qpid::broker::Exchange::shared_ptr mgmtExchange, + qpid::broker::Exchange::shared_ptr directExchange); int getMaxThreads () { return threadPoolSize; } void RegisterClass (std::string packageName, std::string className, @@ -59,7 +59,7 @@ class ManagementBroker : public ManagementAgent ObjectId addObject (ManagementObject* object, uint64_t persistId = 0); void clientAdded (void); - bool dispatchCommand (broker::Deliverable& msg, + bool dispatchCommand (qpid::broker::Deliverable& msg, const std::string& routingKey, const framing::FieldTable* args); @@ -71,7 +71,7 @@ class ManagementBroker : public ManagementAgent private: friend class ManagementAgent; - struct Periodic : public broker::TimerTask + struct Periodic : public qpid::broker::TimerTask { ManagementBroker& broker; @@ -88,7 +88,7 @@ class ManagementBroker : public ManagementAgent uint32_t objIdBank; std::string routingKey; ObjectId connectionRef; - Agent* mgmtObject; + qmf::org::apache::qpid::broker::Agent* mgmtObject; ManagementObject* GetManagementObject (void) const { return mgmtObject; } virtual ~RemoteAgent (); }; @@ -154,12 +154,12 @@ class ManagementBroker : public ManagementAgent framing::Uuid uuid; sys::Mutex addLock; sys::Mutex userLock; - broker::Timer timer; - broker::Exchange::shared_ptr mExchange; - broker::Exchange::shared_ptr dExchange; + qpid::broker::Timer timer; + qpid::broker::Exchange::shared_ptr mExchange; + qpid::broker::Exchange::shared_ptr dExchange; std::string dataDir; uint16_t interval; - broker::Broker* broker; + qpid::broker::Broker* broker; uint16_t bootSequence; uint32_t nextObjectId; uint32_t brokerBank; @@ -178,12 +178,12 @@ class ManagementBroker : public ManagementAgent bool CheckHeader (framing::Buffer& buf, uint8_t *opcode, uint32_t *seq); void SendBuffer (framing::Buffer& buf, uint32_t length, - broker::Exchange::shared_ptr exchange, + qpid::broker::Exchange::shared_ptr exchange, std::string routingKey); void moveNewObjectsLH(); - bool authorizeAgentMessageLH(broker::Message& msg); - void dispatchAgentCommandLH(broker::Message& msg); + bool authorizeAgentMessageLH(qpid::broker::Message& msg); + void dispatchAgentCommandLH(qpid::broker::Message& msg); PackageMap::iterator FindOrAddPackageLH(std::string name); void AddClass(PackageMap::iterator pIter, @@ -208,9 +208,9 @@ class ManagementBroker : public ManagementAgent void handleClassIndLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence); void handleSchemaRequestLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence); void handleSchemaResponseLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence); - void handleAttachRequestLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence, const broker::ConnectionToken* connToken); + void handleAttachRequestLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence, const qpid::broker::ConnectionToken* connToken); void handleGetQueryLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence); - void handleMethodRequestLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence, const broker::ConnectionToken* connToken); + void handleMethodRequestLH (framing::Buffer& inBuffer, std::string replyToKey, uint32_t sequence, const qpid::broker::ConnectionToken* connToken); size_t ValidateSchema(framing::Buffer&); sys::Mutex& getMutex(); |