diff options
author | Robert Gemmell <robbie@apache.org> | 2010-10-01 11:03:35 +0000 |
---|---|---|
committer | Robert Gemmell <robbie@apache.org> | 2010-10-01 11:03:35 +0000 |
commit | af9aae7562262306d59c6119e476ae07c6130510 (patch) | |
tree | 19586a2e8d9dd72ffe6cb7bacc1ebcf915c948a7 /qpid/java/common/src/main/java/org/apache | |
parent | 90d1a072de027f7c67d47a875047027e3ef0c0a0 (diff) | |
download | qpid-python-af9aae7562262306d59c6119e476ae07c6130510.tar.gz |
QPID-2857: Fix issue identified by running FindBugs across the codebase. Close reader when it is no longer required
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1003479 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/java/common/src/main/java/org/apache')
-rw-r--r-- | qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java b/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java index fa26786ec4..516204fbd3 100644 --- a/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java +++ b/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java @@ -374,14 +374,21 @@ public class FileUtils List<String> results = new LinkedList<String>(); BufferedReader reader = new BufferedReader(new FileReader(file)); - while (reader.ready()) + try { - String line = reader.readLine(); - if (line.contains(search)) + while (reader.ready()) { - results.add(line); + String line = reader.readLine(); + if (line.contains(search)) + { + results.add(line); + } } } + finally + { + reader.close(); + } return results; } |