summaryrefslogtreecommitdiff
path: root/qpid/java/common/src/test/java/org/apache/qpid/ssl/TrustManagerTest.java
diff options
context:
space:
mode:
Diffstat (limited to 'qpid/java/common/src/test/java/org/apache/qpid/ssl/TrustManagerTest.java')
-rw-r--r--qpid/java/common/src/test/java/org/apache/qpid/ssl/TrustManagerTest.java262
1 files changed, 222 insertions, 40 deletions
diff --git a/qpid/java/common/src/test/java/org/apache/qpid/ssl/TrustManagerTest.java b/qpid/java/common/src/test/java/org/apache/qpid/ssl/TrustManagerTest.java
index 34ca4e0e03..3b76d81e42 100644
--- a/qpid/java/common/src/test/java/org/apache/qpid/ssl/TrustManagerTest.java
+++ b/qpid/java/common/src/test/java/org/apache/qpid/ssl/TrustManagerTest.java
@@ -37,126 +37,308 @@ import org.apache.qpid.transport.network.security.ssl.SSLUtil;
public class TrustManagerTest extends QpidTestCase
{
- private static final String BROKER_KEYSTORE_PATH = TEST_RESOURCES_DIR + "/ssl/java_broker_keystore.jks";
+ private static final String BROKER_TRUSTSTORE_PATH = TEST_RESOURCES_DIR + "/ssl/java_broker_truststore.jks";
private static final String BROKER_PEERSTORE_PATH = TEST_RESOURCES_DIR + "/ssl/java_broker_peerstore.jks";
private static final String CLIENT_KEYSTORE_PATH = TEST_RESOURCES_DIR + "/ssl/java_client_keystore.jks";
+ private static final String CLIENT_UNTRUSTED_KEYSTORE_PATH = TEST_RESOURCES_DIR + "/ssl/java_client_untrusted_keystore.jks";
private static final String STORE_PASSWORD = "password";
private static final String STORE_TYPE = "JKS";
private static final String DEFAULT_TRUST_MANAGER_ALGORITHM = TrustManagerFactory.getDefaultAlgorithm();
private static final String CERT_ALIAS_APP1 = "app1";
private static final String CERT_ALIAS_APP2 = "app2";
+ private static final String CERT_ALIAS_UNTRUSTED_CLIENT = "untrusted_client";
// retrieves the client certificate's chain from store and returns it as an array
- private X509Certificate[] getClientChain() throws Exception
+ private X509Certificate[] getClientChain(final String storePath, final String alias) throws Exception
{
- final KeyStore ks = SSLUtil.getInitializedKeyStore(CLIENT_KEYSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
- final Certificate[] chain = ks.getCertificateChain(CERT_ALIAS_APP1);
+ final KeyStore ks = SSLUtil.getInitializedKeyStore(storePath, STORE_PASSWORD, STORE_TYPE);
+ final Certificate[] chain = ks.getCertificateChain(alias);
return Arrays.copyOf(chain, chain.length, X509Certificate[].class);
}
- // verifies that peer store is loaded only with client's (peer's) certificates (no CA)
+ // verifies that peer store is loaded only with client's (peer's) app1 certificate (no CA)
private void noCAinPeerStore(final KeyStore ps) throws KeyStoreException
{
final Enumeration<String> aliases = ps.aliases();
while (aliases.hasMoreElements())
{
final String alias = aliases.nextElement();
- if (!alias.equalsIgnoreCase(CERT_ALIAS_APP1) && !alias.equalsIgnoreCase(CERT_ALIAS_APP2))
+ if (!alias.equalsIgnoreCase(CERT_ALIAS_APP1))
{
- fail("Broker's peer store contains other certificate than client's public keys");
+ fail("Broker's peer store contains other certificate than client's app1 public key");
}
}
}
- public void testPeerStoreClientAuthentication() throws Exception
+ /**
+ * Tests that the QpidPeersOnlyTrustManager gives the expected behaviour when loaded separately
+ * with the broker peerstore and truststore.
+ */
+ public void testQpidPeersOnlyTrustManager() throws Exception
{
- // first let's check that peer manager loaded with proper store succeeds
+ // first let's check that peer manager loaded with the PEERstore succeeds
final KeyStore ps = SSLUtil.getInitializedKeyStore(BROKER_PEERSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
this.noCAinPeerStore(ps);
final TrustManagerFactory pmf = TrustManagerFactory.getInstance(DEFAULT_TRUST_MANAGER_ALGORITHM);
pmf.init(ps);
final TrustManager[] delegatePeerManagers = pmf.getTrustManagers();
- boolean peerManagerTested = false;
+
+ X509TrustManager peerManager = null;
for (final TrustManager tm : delegatePeerManagers)
{
if (tm instanceof X509TrustManager)
{
- peerManagerTested = true;
// peer manager is supposed to trust only clients which peers certificates
// are directly in the store. CA signing will not be considered.
- X509TrustManager peerManager = new QpidPeersOnlyTrustManager(ps, (X509TrustManager) tm);
- // since broker's peerstore contains the client's certificate, the check should succeed
- try
- {
- peerManager.checkClientTrusted(this.getClientChain(), "RSA");
- }
- catch (CertificateException e)
- {
- fail("Client's validation against the broker's peer store manager failed.");
- }
+ peerManager = new QpidPeersOnlyTrustManager(ps, (X509TrustManager) tm);
}
}
- assertEquals("No QpidPeersOnlyTrustManager(s) were created from the peer store.", true, peerManagerTested);
- // now let's check that peer manager loaded with improper store fails
- final KeyStore ts = SSLUtil.getInitializedKeyStore(BROKER_KEYSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
+
+ try
+ {
+ // since broker's peerstore contains the client's app1 certificate, the check should succeed
+ peerManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP1), "RSA");
+ }
+ catch (CertificateException e)
+ {
+ fail("Trusted client's validation against the broker's peer store manager failed.");
+ }
+
+ try
+ {
+ // since broker's peerstore does not contain the client's app2 certificate, the check should fail
+ peerManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP2), "RSA");
+ fail("Untrusted client's validation against the broker's peer store manager succeeded.");
+ }
+ catch (CertificateException e)
+ {
+ //expected
+ }
+
+ // now let's check that peer manager loaded with the brokers TRUSTstore fails because
+ // it does not have the clients certificate in it (though it does have a CA-cert that
+ // would otherwise trust the client cert when using the regular trust manager).
+ final KeyStore ts = SSLUtil.getInitializedKeyStore(BROKER_TRUSTSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
final TrustManagerFactory tmf = TrustManagerFactory.getInstance(DEFAULT_TRUST_MANAGER_ALGORITHM);
tmf.init(ts);
final TrustManager[] delegateTrustManagers = tmf.getTrustManagers();
+
+ peerManager = null;
for (final TrustManager tm : delegateTrustManagers)
{
if (tm instanceof X509TrustManager)
{
// peer manager is supposed to trust only clients which peers certificates
// are directly in the store. CA signing will not be considered.
- X509TrustManager peerManager = new QpidPeersOnlyTrustManager(ts, (X509TrustManager) tm);
- // since broker's truststore doesn't contain the client's certificate, the check should fail
- try
- {
- peerManager.checkClientTrusted(this.getClientChain(), "RSA");
- fail("Client's validation against the broker's peer store manager didn't fail.");
- }
- catch (CertificateException e)
- {
- // expected
- }
+ peerManager = new QpidPeersOnlyTrustManager(ts, (X509TrustManager) tm);
}
}
+
+ try
+ {
+ // since broker's truststore doesn't contain the client's app1 certificate, the check should fail
+ // despite the fact that the truststore does have a CA that would otherwise trust the cert
+ peerManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP1), "RSA");
+ fail("Client's validation against the broker's peer store manager didn't fail.");
+ }
+ catch (CertificateException e)
+ {
+ // expected
+ }
+
+ try
+ {
+ // since broker's truststore doesn't contain the client's app2 certificate, the check should fail
+ // despite the fact that the truststore does have a CA that would otherwise trust the cert
+ peerManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP2), "RSA");
+ fail("Client's validation against the broker's peer store manager didn't fail.");
+ }
+ catch (CertificateException e)
+ {
+ // expected
+ }
}
-
- public void testMultipleStoreClientAuthentication() throws Exception
+
+ /**
+ * Tests that the QpidMultipleTrustManager gives the expected behaviour when wrapping a
+ * regular TrustManager against the broker truststore.
+ */
+ public void testQpidMultipleTrustManagerWithRegularTrustStore() throws Exception
+ {
+ final QpidMultipleTrustManager mulTrustManager = new QpidMultipleTrustManager();
+ final KeyStore ts = SSLUtil.getInitializedKeyStore(BROKER_TRUSTSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
+ final TrustManagerFactory tmf = TrustManagerFactory.getInstance(DEFAULT_TRUST_MANAGER_ALGORITHM);
+ tmf.init(ts);
+ final TrustManager[] delegateTrustManagers = tmf.getTrustManagers();
+ boolean trustManagerAdded = false;
+ for (final TrustManager tm : delegateTrustManagers)
+ {
+ if (tm instanceof X509TrustManager)
+ {
+ // add broker's trust manager
+ mulTrustManager.addTrustManager((X509TrustManager) tm);
+ trustManagerAdded = true;
+ }
+ }
+ assertTrue("The regular trust manager for the trust store was not added", trustManagerAdded);
+
+ try
+ {
+ // verify the CA-trusted app1 cert (should succeed)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP1), "RSA");
+ }
+ catch (CertificateException ex)
+ {
+ fail("Trusted client's validation against the broker's multi store manager failed.");
+ }
+
+ try
+ {
+ // verify the CA-trusted app2 cert (should succeed)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP2), "RSA");
+ }
+ catch (CertificateException ex)
+ {
+ fail("Trusted client's validation against the broker's multi store manager failed.");
+ }
+
+ try
+ {
+ // verify the untrusted cert (should fail)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_UNTRUSTED_KEYSTORE_PATH, CERT_ALIAS_UNTRUSTED_CLIENT), "RSA");
+ fail("Untrusted client's validation against the broker's multi store manager unexpectedly passed.");
+ }
+ catch (CertificateException ex)
+ {
+ // expected
+ }
+ }
+
+ /**
+ * Tests that the QpidMultipleTrustManager gives the expected behaviour when wrapping a
+ * QpidPeersOnlyTrustManager against the broker peerstore.
+ */
+ public void testQpidMultipleTrustManagerWithPeerStore() throws Exception
{
final QpidMultipleTrustManager mulTrustManager = new QpidMultipleTrustManager();
- final KeyStore ts = SSLUtil.getInitializedKeyStore(BROKER_KEYSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
+ final KeyStore ps = SSLUtil.getInitializedKeyStore(BROKER_PEERSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
+ final TrustManagerFactory pmf = TrustManagerFactory.getInstance(DEFAULT_TRUST_MANAGER_ALGORITHM);
+ pmf.init(ps);
+ final TrustManager[] delegatePeerManagers = pmf.getTrustManagers();
+ boolean peerManagerAdded = false;
+ for (final TrustManager tm : delegatePeerManagers)
+ {
+ if (tm instanceof X509TrustManager)
+ {
+ // add broker's peer manager
+ mulTrustManager.addTrustManager(new QpidPeersOnlyTrustManager(ps, (X509TrustManager) tm));
+ peerManagerAdded = true;
+ }
+ }
+ assertTrue("The QpidPeersOnlyTrustManager for the peerstore was not added", peerManagerAdded);
+
+ try
+ {
+ // verify the trusted app1 cert (should succeed as the key is in the peerstore)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP1), "RSA");
+ }
+ catch (CertificateException ex)
+ {
+ fail("Trusted client's validation against the broker's multi store manager failed.");
+ }
+
+ try
+ {
+ // verify the untrusted app2 cert (should fail as the key is not in the peerstore)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP2), "RSA");
+ fail("Untrusted client's validation against the broker's multi store manager unexpectedly passed.");
+ }
+ catch (CertificateException ex)
+ {
+ // expected
+ }
+
+ try
+ {
+ // verify the untrusted cert (should fail as the key is not in the peerstore)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_UNTRUSTED_KEYSTORE_PATH, CERT_ALIAS_UNTRUSTED_CLIENT), "RSA");
+ fail("Untrusted client's validation against the broker's multi store manager unexpectedly passed.");
+ }
+ catch (CertificateException ex)
+ {
+ // expected
+ }
+ }
+
+ /**
+ * Tests that the QpidMultipleTrustManager gives the expected behaviour when wrapping a
+ * QpidPeersOnlyTrustManager against the broker peerstore, a regular TrustManager
+ * against the broker truststore.
+ */
+ public void testQpidMultipleTrustManagerWithTrustAndPeerStores() throws Exception
+ {
+ final QpidMultipleTrustManager mulTrustManager = new QpidMultipleTrustManager();
+ final KeyStore ts = SSLUtil.getInitializedKeyStore(BROKER_TRUSTSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
final TrustManagerFactory tmf = TrustManagerFactory.getInstance(DEFAULT_TRUST_MANAGER_ALGORITHM);
tmf.init(ts);
final TrustManager[] delegateTrustManagers = tmf.getTrustManagers();
+ boolean trustManagerAdded = false;
for (final TrustManager tm : delegateTrustManagers)
{
if (tm instanceof X509TrustManager)
{
// add broker's trust manager
mulTrustManager.addTrustManager((X509TrustManager) tm);
+ trustManagerAdded = true;
}
}
+ assertTrue("The regular trust manager for the trust store was not added", trustManagerAdded);
+
final KeyStore ps = SSLUtil.getInitializedKeyStore(BROKER_PEERSTORE_PATH, STORE_PASSWORD, STORE_TYPE);
final TrustManagerFactory pmf = TrustManagerFactory.getInstance(DEFAULT_TRUST_MANAGER_ALGORITHM);
pmf.init(ps);
final TrustManager[] delegatePeerManagers = pmf.getTrustManagers();
+ boolean peerManagerAdded = false;
for (final TrustManager tm : delegatePeerManagers)
{
if (tm instanceof X509TrustManager)
{
// add broker's peer manager
mulTrustManager.addTrustManager(new QpidPeersOnlyTrustManager(ps, (X509TrustManager) tm));
+ peerManagerAdded = true;
}
}
+ assertTrue("The QpidPeersOnlyTrustManager for the peerstore was not added", peerManagerAdded);
+
+ try
+ {
+ // verify the CA-trusted app1 cert (should succeed)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP1), "RSA");
+ }
+ catch (CertificateException ex)
+ {
+ fail("Trusted client's validation against the broker's multi store manager failed.");
+ }
+
+ try
+ {
+ // verify the CA-trusted app2 cert (should succeed)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_KEYSTORE_PATH, CERT_ALIAS_APP2), "RSA");
+ }
+ catch (CertificateException ex)
+ {
+ fail("Trusted client's validation against the broker's multi store manager failed.");
+ }
+
try
{
- mulTrustManager.checkClientTrusted(this.getClientChain(), "RSA");
+ // verify the untrusted cert (should fail)
+ mulTrustManager.checkClientTrusted(this.getClientChain(CLIENT_UNTRUSTED_KEYSTORE_PATH, CERT_ALIAS_UNTRUSTED_CLIENT), "RSA");
+ fail("Untrusted client's validation against the broker's multi store manager unexpectedly passed.");
}
catch (CertificateException ex)
{
- fail("Client's validation against the broker's multi store manager failed.");
+ // expected
}
}
}
View Lorry Controller Status