From 1ab07197127e990da2c765ea0ffa5fd8ca47b7b6 Mon Sep 17 00:00:00 2001 From: Kim van der Riet Date: Tue, 26 Jun 2012 18:23:27 +0000 Subject: QPID-3858: WIP - fixed a few logic errors and race conditions in the consume and transactional code git-svn-id: https://svn.apache.org/repos/asf/qpid/branches/asyncstore@1354149 13f79535-47bb-0310-9956-ffa450edef68 --- cpp/src/qpid/asyncStore/TxnHandleImpl.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'cpp/src/qpid/asyncStore') diff --git a/cpp/src/qpid/asyncStore/TxnHandleImpl.cpp b/cpp/src/qpid/asyncStore/TxnHandleImpl.cpp index af3a8f01cf..c5371f161c 100644 --- a/cpp/src/qpid/asyncStore/TxnHandleImpl.cpp +++ b/cpp/src/qpid/asyncStore/TxnHandleImpl.cpp @@ -110,7 +110,10 @@ void TxnHandleImpl::createLocalXid() { uuid_t uuid; + + // TODO: This call might not be thread safe - Valgrind's helgrind tool emits warnings for this: ::uuid_generate_random(uuid); + char uuidStr[37]; // 36-char uuid + trailing '\0' ::uuid_unparse(uuid, uuidStr); m_xid.assign(uuidStr); -- cgit v1.2.1