summaryrefslogtreecommitdiff
path: root/java/broker/src/test/java/org/apache/qpid/server/virtualhost/plugins/SlowConsumerDetectionConfigurationTest.java
blob: e2375c579b54a4cf24ef4c9be1a9fa5f8596112a (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
/*
 *
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 *
 */
package org.apache.qpid.server.virtualhost.plugins;

import org.apache.commons.configuration.CompositeConfiguration;
import org.apache.commons.configuration.ConfigurationException;
import org.apache.commons.configuration.XMLConfiguration;

import org.apache.qpid.server.configuration.plugins.SlowConsumerDetectionConfiguration;
import org.apache.qpid.server.util.InternalBrokerBaseCase;

import java.util.concurrent.TimeUnit;

/**
 *  Provide Unit Test coverage of the virtualhost SlowConsumer Configuration
 *  This is what controls how often the plugin will execute
 */
public class SlowConsumerDetectionConfigurationTest extends InternalBrokerBaseCase
{

    /**
     * Default Testing:
     *
     * Provide a fully complete and valid configuration specifying 'delay' and
     * 'timeunit' and ensure that it is correctly processed.
     *
     * Ensure no exceptions are thrown and that we get the same values back that
     * were put into the configuration.
     */
    public void testConfigLoadingValidConfig()
    {
        SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

        XMLConfiguration xmlconfig = new XMLConfiguration();

        long DELAY=10;
        String TIMEUNIT=TimeUnit.MICROSECONDS.toString();
        xmlconfig.addProperty("delay", String.valueOf(DELAY));
        xmlconfig.addProperty("timeunit", TIMEUNIT);

        // Create a CompositeConfiguration as this is what the broker uses
        CompositeConfiguration composite = new CompositeConfiguration();
        composite.addConfiguration(xmlconfig);

        try
        {
            config.setConfiguration("", composite);
        }
        catch (ConfigurationException e)
        {
            e.printStackTrace();
            fail(e.getMessage());
        }

        assertEquals("Delay not correctly returned.", DELAY, config.getDelay());
        assertEquals("TimeUnit not correctly returned.",
                     TIMEUNIT, String.valueOf(config.getTimeUnit()));
    }

    /**
       * Default Testing:
       *
       * Test Missing TimeUnit value gets default.
       *
       * The TimeUnit value is optional and default to SECONDS.
       *
       * Test that if we do not specify a TimeUnit then we correctly get seconds.
       *
       * Also verify that relying on the default does not impact the setting of
       * the 'delay' value.
       *
       */
      public void testConfigLoadingMissingTimeUnitDefaults()
      {
          SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

          XMLConfiguration xmlconfig = new XMLConfiguration();

          long DELAY=10;
          xmlconfig.addProperty("delay", String.valueOf(DELAY));

          // Create a CompositeConfiguration as this is what the broker uses
          CompositeConfiguration composite = new CompositeConfiguration();
          composite.addConfiguration(xmlconfig);
          try
          {
              config.setConfiguration("", composite);
          }
          catch (ConfigurationException e)
          {
              e.printStackTrace();
              fail(e.getMessage());
          }

          assertEquals("Delay not correctly returned.", DELAY, config.getDelay());
          assertEquals("Default TimeUnit incorrect", TimeUnit.SECONDS, config.getTimeUnit());
      }    

    /**
     * Input Testing:
     *
     * TimeUnit parsing requires the String value be in UpperCase.
     * Ensure we can handle when the user doesn't know this.
     *
     * Same test as 'testConfigLoadingValidConfig' but checking that
     * the timeunit field is not case sensitive.
     * i.e. the toUpper is being correctly applied.
     */
    public void testConfigLoadingValidConfigStrangeTimeUnit()
    {
        SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

        XMLConfiguration xmlconfig = new XMLConfiguration();

        long DELAY=10;

        xmlconfig.addProperty("delay", DELAY);
        xmlconfig.addProperty("timeunit", "MiCrOsEcOnDs");

        // Create a CompositeConfiguration as this is what the broker uses
        CompositeConfiguration composite = new CompositeConfiguration();
        composite.addConfiguration(xmlconfig);

        try
        {
            config.setConfiguration("", composite);
        }
        catch (ConfigurationException e)
        {
            e.printStackTrace();
            fail(e.getMessage());
        }

        assertEquals("Delay not correctly returned.", DELAY, config.getDelay());
        assertEquals("TimeUnit not correctly returned.",
                     TimeUnit.MICROSECONDS.toString(), String.valueOf(config.getTimeUnit()));

    }

    /**
     * Failure Testing:
     *
     * Test that delay must be long not a string value.
     * Provide a delay as a written value not a long. 'ten'.
     *
     * This should throw a configuration exception which is being trapped and
     * verified to be the right exception, a NumberFormatException.
     *
     */
    public void testConfigLoadingInValidDelayString()
    {
        SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

        XMLConfiguration xmlconfig = new XMLConfiguration();

        xmlconfig.addProperty("delay", "ten");
        xmlconfig.addProperty("timeunit", TimeUnit.MICROSECONDS.toString());

        // Create a CompositeConfiguration as this is what the broker uses
        CompositeConfiguration composite = new CompositeConfiguration();
        composite.addConfiguration(xmlconfig);

        try
        {
            config.setConfiguration("", composite);
            fail("Configuration should fail to validate");
        }
        catch (ConfigurationException e)
        {
            Throwable cause = e.getCause();

            assertEquals("Cause not correct", NumberFormatException.class, cause.getClass());
        }
    }

    /**
     * Failure Testing:
     *
     * Test that negative delays are invalid.
     *
     * Delay must be a positive value as negative delay means doesn't make sense.
     *
     * Configuration exception with a useful message should be thrown here.
     *
     */
    public void testConfigLoadingInValidDelayNegative()
    {
        SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

        XMLConfiguration xmlconfig = new XMLConfiguration();

        xmlconfig.addProperty("delay", "-10");
        xmlconfig.addProperty("timeunit", TimeUnit.MICROSECONDS.toString());

        // Create a CompositeConfiguration as this is what the broker uses
        CompositeConfiguration composite = new CompositeConfiguration();
        composite.addConfiguration(xmlconfig);

        try
        {
            config.setConfiguration("", composite);
            fail("Configuration should fail to validate");
        }
        catch (ConfigurationException e)
        {
            Throwable cause = e.getCause();

            assertNotNull("Configuration Exception must not be null.", cause);
            assertEquals("Cause not correct",
                         ConfigurationException.class, cause.getClass());
            assertEquals("Incorrect message.",
                         "SlowConsumerDetectionConfiguration: 'delay' must be a Positive Long value.",
                         cause.getMessage());
        }
    }

    /**
     * Failure Testing:
     *
     *  Test that delay cannot be 0.
     *
     * A zero delay means run constantly. This is not how VirtualHostTasks
     * are designed to be run so we dis-allow the use of 0 delay.
     *
     * Same test as 'testConfigLoadingInValidDelayNegative' but with a 0 value.
     *
     */
    public void testConfigLoadingInValidDelayZero()
    {
        SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

        XMLConfiguration xmlconfig = new XMLConfiguration();

        xmlconfig.addProperty("delay", "0");
        xmlconfig.addProperty("timeunit", TimeUnit.MICROSECONDS.toString());

        // Create a CompositeConfiguration as this is what the broker uses
        CompositeConfiguration composite = new CompositeConfiguration();
        composite.addConfiguration(xmlconfig);

        try
        {
            config.setConfiguration("", composite);
            fail("Configuration should fail to validate");
        }
        catch (ConfigurationException e)
        {
            Throwable cause = e.getCause();

            assertNotNull("Configuration Exception must not be null.", cause);
            assertEquals("Cause not correct",
                         ConfigurationException.class, cause.getClass());
            assertEquals("Incorrect message.",
                         "SlowConsumerDetectionConfiguration: 'delay' must be a Positive Long value.",
                         cause.getMessage());
        }
    }

    /**
     * Failure Testing:
     *
     * Test that missing delay fails.
     * If we have no delay then we do not pick a default. So a Configuration
     * Exception is thrown.
     *
     * */
    public void testConfigLoadingInValidMissingDelay()
    {
        SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

        XMLConfiguration xmlconfig = new XMLConfiguration();

        xmlconfig.addProperty("timeunit", TimeUnit.SECONDS.toString());

        // Create a CompositeConfiguration as this is what the broker uses
        CompositeConfiguration composite = new CompositeConfiguration();
        composite.addConfiguration(xmlconfig);
        try
        {
            config.setConfiguration("", composite);
            fail("Configuration should fail to validate");
        }
        catch (ConfigurationException e)
        {
            assertEquals("Incorrect message.", "SlowConsumerDetectionConfiguration: unable to configure invalid delay:null", e.getMessage());
        }
    }

    /**
     * Failure Testing:
     *
     * Test that erroneous TimeUnit fails.
     *
     * Valid TimeUnit values vary based on the JVM version i.e. 1.6 added HOURS/DAYS etc.
     *
     * We don't test the values for TimeUnit are accepted other than MILLISECONDS in the
     * positive testing at the start.
     *
     * Here we ensure that an erroneous for TimeUnit correctly throws an exception.
     *
     * We test with 'foo', which will never be a TimeUnit
     *
     */
    public void testConfigLoadingInValidTimeUnit()
    {
        SlowConsumerDetectionConfiguration config = new SlowConsumerDetectionConfiguration();

        String TIMEUNIT = "foo";
        XMLConfiguration xmlconfig = new XMLConfiguration();

        xmlconfig.addProperty("delay", "10");
        xmlconfig.addProperty("timeunit", TIMEUNIT);

        // Create a CompositeConfiguration as this is what the broker uses
        CompositeConfiguration composite = new CompositeConfiguration();
        composite.addConfiguration(xmlconfig);
        try
        {
            config.setConfiguration("", composite);
            fail("Configuration should fail to validate");
        }
        catch (ConfigurationException e)
        {
            assertEquals("Incorrect message.", "Unable to configure Slow Consumer Detection invalid TimeUnit:" + TIMEUNIT, e.getMessage());
        }
    }


}