diff options
author | Alan Antonuk <alan.antonuk@gmail.com> | 2016-12-04 21:36:20 -0800 |
---|---|---|
committer | Alan Antonuk <alan.antonuk@gmail.com> | 2016-12-04 21:36:20 -0800 |
commit | 2ca1774489328cde71195f5fa95e17cf3a80cb8a (patch) | |
tree | 1f8b0cbab66372dc9763c8ccb46a75dd3c272da8 | |
parent | 7f92d532360dd254bf0484085e7a51b812cc578f (diff) | |
download | rabbitmq-c-2ca1774489328cde71195f5fa95e17cf3a80cb8a.tar.gz |
Lib: re-order NULL check in empty_blocklist
NULL check in empty_blockless was happening after its used. This
would've likely resulted in crashes if it was hit.
Found with PVS Studio run.
-rw-r--r-- | librabbitmq/amqp_mem.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/librabbitmq/amqp_mem.c b/librabbitmq/amqp_mem.c index 9ee393c..aa8439b 100644 --- a/librabbitmq/amqp_mem.c +++ b/librabbitmq/amqp_mem.c @@ -75,10 +75,10 @@ static void empty_blocklist(amqp_pool_blocklist_t *x) { int i; - for (i = 0; i < x->num_blocks; i++) { - free(x->blocklist[i]); - } if (x->blocklist != NULL) { + for (i = 0; i < x->num_blocks; i++) { + free(x->blocklist[i]); + } free(x->blocklist); } x->num_blocks = 0; |