summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIsaac Slavitt <isaac.slavitt@gmail.com>2017-04-07 11:09:22 +0200
committerAshley Camba <ashwoods@gmail.com>2017-09-06 16:55:52 +0200
commit9c2bbd604fb0c223d15032615951bfd9b1adf721 (patch)
tree0ed3f6ebd390688b58e8ecc25cf16902c0d19640
parentbc9d9969fb0efac5569e3588af4d6bde0e11136a (diff)
downloadraven-9c2bbd604fb0c223d15032615951bfd9b1adf721.tar.gz
Update Django message ref example for 1.11, fixes #993
- Use a `TemplateResponse` (backwards compatible to Django 1.7) instead of trying to pass a `Context` object to an instance of `django.template.backends.django.Template.render` which is no longer allowed (see #993) - Verified working with example app (Python 3.5, Django 1.11) before changing example in docs
-rw-r--r--docs/integrations/django.rst10
1 files changed, 4 insertions, 6 deletions
diff --git a/docs/integrations/django.rst b/docs/integrations/django.rst
index bf12bfa..c10b7ea 100644
--- a/docs/integrations/django.rst
+++ b/docs/integrations/django.rst
@@ -196,8 +196,7 @@ reference ID. The first step in doing this is creating a custom
from django.conf.urls.defaults import *
from django.views.defaults import page_not_found, server_error
- from django.template import Context, loader
- from django.http import HttpResponseServerError
+ from django.template.response import TemplateResponse
def handler500(request):
"""500 error handler which includes ``request`` in the context.
@@ -206,10 +205,9 @@ reference ID. The first step in doing this is creating a custom
Context: None
"""
- t = loader.get_template('500.html') # You need to create a 500.html template.
- return HttpResponseServerError(t.render(Context({
- 'request': request,
- })))
+ context = {'request': request}
+ template_name = '500.html' # You need to create a 500.html template.
+ return TemplateResponse(request, template_name, context, status=500)
Once we've successfully added the :data:`request` context variable, adding the
Sentry reference ID to our :file:`500.html` is simple: