Automatically strip whitespace in DSNs. This fixes #907

3 files changed, 16 insertions, 1 deletions

diff --git a/CHANGES b/CHANGES
index 2d4e599..7849fc4 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,8 @@
+Version 5.33.0
+--------------
+
+* Strip whitespace from DNSs automatically.
+
 Version 5.32.0
 --------------
 
diff --git a/raven/conf/remote.py b/raven/conf/remote.py
index 10149c4..d7f0605 100644
--- a/raven/conf/remote.py
+++ b/raven/conf/remote.py
@@ -84,7 +84,7 @@ class RemoteConfig(object):
         if PY2:
             value = to_string(value)
 
-        url = urlparse(value)
+        url = urlparse(value.strip())
 
         if url.scheme not in ('http', 'https'):
             warnings.warn('Transport selection via DSN is deprecated. You should explicitly pass the transport class to Client() instead.')
diff --git a/tests/conf/tests.py b/tests/conf/tests.py
index 9caa242..e02a1fb 100644
--- a/tests/conf/tests.py
+++ b/tests/conf/tests.py
@@ -10,6 +10,16 @@ from raven.utils.testutils import TestCase
 
 
 class RemoteConfigTest(TestCase):
+    def test_path_strip(self):
+        dsn = 'https://foo:bar@sentry.local/app/1\n'
+        res = RemoteConfig.from_string(dsn)
+        assert res.project == '1'
+        assert res.base_url == 'https://sentry.local/app'
+        assert res.store_endpoint == 'https://sentry.local/app/api/1/store/'
+        assert res.public_key == 'foo'
+        assert res.secret_key == 'bar'
+        assert res.options == {}
+
     def test_path(self):
         dsn = 'https://foo:bar@sentry.local/app/1'
         res = RemoteConfig.from_string(dsn)