diff options
| author | Damien <damien@codeyellow.nl> | 2016-06-16 15:18:38 +0200 |
|---|---|---|
| committer | Damien <damien@codeyellow.nl> | 2016-06-22 14:50:25 +0200 |
| commit | 0e1a27441d6e40a2d87256477975ba3935d74161 (patch) | |
| tree | d8db8e2eca855ffcc20a4721962646e5d9edf818 | |
| parent | c441cf0b6ad46408a53ff15a8e82ca45c40389a1 (diff) | |
| download | raven-0e1a27441d6e40a2d87256477975ba3935d74161.tar.gz | |
add type check for sentry initialization for flask
| -rw-r--r-- | raven/contrib/flask.py | 3 | ||||
| -rw-r--r-- | tests/contrib/flask/tests.py | 3 |
2 files changed, 6 insertions, 0 deletions
diff --git a/raven/contrib/flask.py b/raven/contrib/flask.py index 8086d7f..c23b92b 100644 --- a/raven/contrib/flask.py +++ b/raven/contrib/flask.py @@ -105,6 +105,9 @@ class Sentry(object): def __init__(self, app=None, client=None, client_cls=Client, dsn=None, logging=False, logging_exclusions=None, level=logging.NOTSET, wrap_wsgi=None, register_signal=True): + if client and not isinstance(client, Client): + raise TypeError('client should an instance of Client') + self.dsn = dsn self.logging = logging self.logging_exclusions = logging_exclusions diff --git a/tests/contrib/flask/tests.py b/tests/contrib/flask/tests.py index ab7619f..0530216 100644 --- a/tests/contrib/flask/tests.py +++ b/tests/contrib/flask/tests.py @@ -283,6 +283,9 @@ class FlaskTest(BaseTest): some_other_logger = logging.getLogger("some_other_logger") self.assertTrue(some_other_logger.propagate) + def test_check_client_type(self): + self.assertRaises(TypeError, lambda _: Sentry(self.app, "oops, I'm putting my DSN instead")) + class FlaskLoginTest(BaseTest): |