summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArnav Kumar <arnav@arnavkumar.com>2017-04-04 02:13:58 +0800
committerArnav Kumar <arnav@arnavkumar.com>2017-04-04 02:13:58 +0800
commitf6ec18d1a233ed4fe6596db0edda8a6e63a4e6ec (patch)
tree7ef1e3edefd451a1473836ba140f8c197be5e3f0
parent2fea4c89999ba18cb4111fea19e61a30a9b65f32 (diff)
downloadraven-f6ec18d1a233ed4fe6596db0edda8a6e63a4e6ec.tar.gz
Stop type checking sample_rate in SentryHandler
-rw-r--r--raven/handlers/logging.py5
-rw-r--r--tests/handlers/logging/tests.py6
2 files changed, 0 insertions, 11 deletions
diff --git a/raven/handlers/logging.py b/raven/handlers/logging.py
index a101646..39f60d8 100644
--- a/raven/handlers/logging.py
+++ b/raven/handlers/logging.py
@@ -175,11 +175,6 @@ class SentryHandler(logging.Handler, object):
kwargs.update(handler_kwargs)
sample_rate = extra.pop('sample_rate', None)
- try:
- if sample_rate is not None:
- sample_rate = float(sample_rate)
- except ValueError:
- sample_rate = None
return self.client.capture(
event_type, stack=stack, data=data,
diff --git a/tests/handlers/logging/tests.py b/tests/handlers/logging/tests.py
index 8218b05..5b6dc5b 100644
--- a/tests/handlers/logging/tests.py
+++ b/tests/handlers/logging/tests.py
@@ -273,12 +273,6 @@ class LoggingIntegrationTest(TestCase):
self.assertEqual(len(self.client.events), 1)
- def test_sample_rate_bad_values(self):
- record = self.make_record('Message', extra={'sample_rate': 'foo'})
- self.handler.emit(record)
-
- self.assertEqual(len(self.client.events), 1)
-
class LoggingHandlerTest(TestCase):
def test_client_arg(self):